fix(kirocrew): mount EBS-backed workspace - #107
Conversation
Fixes #105 Crew: Bode (Kiro Crew Issue Radar)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b63df9afc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mount --bind /mnt/ebs-data/workplace /home/ec2-user/workplace | ||
| fi | ||
| if ! grep -qF "/mnt/ebs-data/workplace /home/ec2-user/workplace none bind 0 0" /etc/fstab; then | ||
| echo "/mnt/ebs-data/workplace /home/ec2-user/workplace none bind 0 0" >> /etc/fstab |
There was a problem hiding this comment.
On a reboot where the EBS volume is temporarily unavailable, its /mnt/ebs-data fstab entry is allowed to fail via nofail, but this new bind-mount entry is still required. Because /mnt/ebs-data/workplace then does not exist on the underlying root filesystem, the bind mount fails and can prevent local-fs.target from completing, potentially leaving the instance in emergency mode. Mark this dependent mount as non-fatal while preserving its ordering after /mnt/ebs-data.
Useful? React with 👍 / 👎.
Address review feedback by making the dependent bind mount non-fatal when the EBS volume is unavailable, preserving mount ordering, and migrating the legacy fstab entry.
1 participant
Summary
/mnt/ebs-data/workplaceat/home/ec2-user/workplaceduring bootstrap, migrate existing workspace content, and persist the bind mount in/etc/fstab.Verification
bash tests/test-kirocrew-ebs.sh— base failed 6/6 assertions; implementation passes 7/7.bash tests/test-sync-registry.sh— 46/0.bash packs/kirocrew/test.sh— 73/0.bash tests/test-pack-contracts.sh— 177/0.git diff --checkpass.bash deploy/test-bootstrap.shreports one inherited failure from two pre-existingSC1090warnings; pristinemainreproduces the same warning-only failure. No CI or gate configuration was changed.Fixes #105