chore(deps-dev): bump @babel/core from 7.16.0 to 7.29.6 - #942
Open
dependabot[bot] wants to merge 8 commits into
Open
chore(deps-dev): bump @babel/core from 7.16.0 to 7.29.6#942dependabot[bot] wants to merge 8 commits into
dependabot[bot] wants to merge 8 commits into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
Collaborator
|
@dependabot rebase |
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.16.0 to 7.29.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.6/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 7.29.6 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/babel/core-7.29.6
branch
from
August 31, 2026 18:49
67fc5ee to
c5944a7
Compare
rollup 3 loads rollup.config.js as an ES module. rollup 2 transpiled it to CommonJS first. The config uses require(), so rollup 3 fails with "require is not defined in ES module scope" and the build never starts. rollup moved from 2.60.0 to 3.29.5 in #925 and nothing detected this, because no CI step built the package. Moving forward instead is not possible today. @wessberg/rollup-plugin-ts 1.1.73 does not support the rollup 3 plugin API, and its successor rollup-plugin-ts 3.4.5 depends on browserslist-generator, which uses the removed `assert { type: ... }` import syntax that Node 22 and Node 24 both reject. A forward fix requires upgrading TypeScript off 3.8.3. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Nothing in this repo imports webpack. The build is rollup, and Storybook resolves its own nested webpack 4.46.0, which is the version Storybook 6.3 expects. The hoisted webpack 5.94.0 served nothing. It also broke the build. tsconfig typeRoots includes every @types/* package as a global type, which pulls in webpack 5's bundled types.d.ts. TypeScript 3.8.3 cannot parse it and fails with "Property or signature expected" at types.d.ts:1894. webpack 4 ships no types.d.ts, so removing the direct dependency clears the error at its source. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rollup.config.js mixed ES module imports with a CommonJS require. Read the file with fs instead, so the config is valid ES module syntax. No behaviour change under rollup 2. This stops the same failure recurring if rollup 3 is attempted again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jdstrand
force-pushed
the
dependabot/npm_and_yarn/babel/core-7.29.6
branch
from
August 31, 2026 19:33
32c7de9 to
4a6aba7
Compare
CI ran yarn ci, which is test, lint and typecheck. It never ran the rollup build, so nothing verified the artifact this package publishes. The build was broken from 2024-09-24 until the earlier commits in this branch. Two dependency bumps caused it and neither was detected, because no CI step built the package. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
webpack v4 uses MD4 which is removed from openssl 3. node 24 uses openssl 3, so pass NODE_OPTIONS=--openssl-legacy-provider to storybook until we can upgrade.
eatondustin1
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @babel/core from 7.16.0 to 7.29.6.
In testing this, it was discovered the PR #925 broke CI when moving
rollupfrom 2.60.0 to 3.29.5. CI did not runyarn build, so nothing detected this. Downgrade to^2.60.0for now since moving forward is not possible without upgrading away from TypeScript 3.8.3, which is a much larger effort. Make a small change torollupconfig to make it forward compatible withrollup3 when we do eventually go there.Additionally drop the unused top-level
webpackdevDependency (storybook pulls in its own webpack v4). Having the top-level webpack v5 also broke the build sincetsconfigwould include webpack v5's bundled types, which TypeScript 3.8.3 could not parse.Update to
cimg/node:24.20, which fixes the build issue the original dependabot commit for this PR introduced.Run
yarn buildin CI so we can detect things like therollupregression in CI (I've also made the CIbuildtarget required).webpackv4 uses MD4 which is removed from openssl 3. Newer versions of node (after 14) use openssl 3, so passNODE_OPTIONS=--openssl-legacy-providerto storybook (which calls webpack) until we can upgrade.Run
yarn build-storybookin CI.