nori_regression: point the model list at Synthefy's docs instead of duplicating it - #155
Closed
ajanbekzat wants to merge 1 commit into
Closed
ajanbekzat wants to merge 1 commit into
ajanbekzat wants to merge 1 commit into
Conversation
…uplicating it The README, the model argument's help text, the retired-slug error and the TOML config each carried their own list of Nori slugs. That list is Synthefy's to publish and changes when they release a variant, so the copies went stale: they name only nori-30m and nori-6m, while nori-100m and nori-30m-thinking-medium are current. Each copy is now a pointer to https://docs.synthefy.com/nori/quickstart#models, which is the authoritative list. The plugin still names its own default, since that is the plugin's behaviour rather than the vendor's catalogue. The two cold-start figures quoted per slug are replaced by a range, for the same reason: they were measured against particular variants and a cold start has since been observed close to four minutes.
Contributor
Author
|
Folded into #154 so the plugin's Synthefy-facing details land in one change. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The plugin kept its own list of Nori model slugs in four places: the README's "Supported models" table, the
modelargument's help text, the retired-slug error message, and the commented TOML config. Each is now a pointer to Synthefy's published list at docs.synthefy.com/nori/quickstart#models.The plugin still names its own default (
synthefy/nori-30m), because that is the plugin's behaviour rather than the vendor's catalogue.Why
The copies were already stale. They list
synthefy/nori-30mandsynthefy/nori-6monly, while Synthefy currently publishes four entries, includingsynthefy/nori-100mand an API-onlysynthefy/nori-30m-thinking-medium. A user reading this README would not know the larger model exists.Which models exist is not something this plugin can keep correct: it changes when Synthefy releases a variant, with no signal to this repository. Pointing at the vendor's list removes that failure mode instead of refreshing it once.
Also in this change
The per-slug cold-start figures ("about 69 seconds for nori-6m and 125 seconds for nori-30m") are replaced by a range. They were measured against two specific variants, and a cold start has since been observed at close to four minutes, so a precise pair of numbers reads as more of a guarantee than it is. The
request_timeoutdefault of300sis unchanged and still absorbs it.Testing
The retired-slug error was rendered to confirm the new interpolation:
Note
This is independent of #154, which renames the plugin's API key environment variable. Both touch
README.mdbut in different sections, so they can merge in either order.