Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .changeset/base-ui-native-button-native-render.md

This file was deleted.

18 changes: 18 additions & 0 deletions packages/nk-dev/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# @ingram-tech/nk-dev

## 0.16.1

### Patch Changes

- 54eec07: `nextkit/base-ui-native-button` now only inspects components that actually
accept `nativeButton`: Button, PopoverTrigger, Switch and the menu items.

Keying on the `Button` / `Trigger` name suffixes was wrong twice. A
`*Trigger` builds on `useButton` internally but does not expose the prop, so
the rule demanded code that does not type-check; and a render target named
`*Button` is Base UI's own primitive or a wrapper on it, which renders a
native `<button>`, where `nativeButton={false}` earns the inverse runtime
warning. A locally defined component that merely shares the name (a
SidebarMenuButton) took no such prop either.

On one site this took the rule from 81 reports, 55 of them wrong and the rest
unfixable as suggested, to only the genuine `Button render={<Link />}` cases.

## 0.16.0

### Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/nk-dev/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ingram-tech/nk-dev",
"version": "0.16.0",
"version": "0.16.1",
"description": "The nextkit dev toolchain in one package: the `nk` CLI plus shared oxlint/oxfmt, TypeScript, and Vitest config, the format-on-commit hook, and the AI agent guide. `nk init` scaffolds a site to use it.",
"license": "MIT",
"type": "module",
Expand Down