Repository navigation
[-]:feat/ Send purchase conversion after payment - #2209
Merged
Merged
Conversation
Deploying drive-web with
|
| Latest commit: |
d8c67ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07b65152.drive-web.pages.dev |
| Branch Preview URL: | https://fix-impact-conversion-on-pay.drive-web.pages.dev |
|
jaaaaavier
marked this pull request as ready for review
October 13, 2026 15:29
jaaaaavier
requested review from
a team,
CandelR,
larryrider and
xabg2
as code owners
October 13, 2026 15:29
larryrider
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Background: In the current situation, conversions are tracked once the user has completed registration; this is causing us to lose conversions. Therefore, in this PR, let’s propose tracking conversions once payment has been completed. To do this:
analytics.service.ts
Buyer without account return Stripe customer (
cus_…) and checkout email.analytics/types.ts: PurchaseBuyer type.
impact.service.ts
ga.service.ts: trackPurchase(buyer) receives the buyer instead of reading the user.
useUserPayment.ts: passes the Stripe customerId when saving the payment data.
auth.service.ts: back to its state before Account setup only sends the signup event.
types.ts and storage-keys.ts: checkout_customer_id replaces is_passwordless_purchase and is cleared with the rest of the payment data.
Updated unit tests, and added cases for buyers without an account, without a Stripe customer, and logged in.
Related Issues
Related Pull Requests
Checklist
Testing Process
cus_…customer to the Impact service. Impact accepted it and queued it.Additional Notes