OAuth2 VSCode - #1799
Open
isc-klu wants to merge 27 commits into
Open
Conversation
isc-klu
marked this pull request as ready for review
July 2, 2026 18:46
isc-bsaviano
requested changes
Jul 24, 2026
| if (serverName) { | ||
| panel.tooltip = new vscode.MarkdownString(`Connected to \`${host}:${port}${pathPrefix}\` as \`${username}\``); | ||
| panel.tooltip = new vscode.MarkdownString( | ||
| `Connected to \`${host}:${port}${pathPrefix}\` as \`${auth.username}\`` |
Contributor
There was a problem hiding this comment.
Does this code block (and others) need to be able to handle the OAuth case where there is no username?
Collaborator
Author
There was a problem hiding this comment.
Currently, when auth is OAuth2, the username is hardcoded to "OAuth2User". Is this behavior okay?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors authentication throughout the extension to use the Authorization class from @intersystems-community/intersystems-servermanager instead of directly managing username/password strings.
Key changes: