Skip to content

change ShellScript() to return a status #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isc-cborbonm merged 6 commits into from
Jul 29, 2026
Merged

change ShellScript() to return a status #1211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84d2930
change ShellScript() to return a status
Jul 29, 2026
2cbdb9f
Merge branch 'main' into fix-1186
isc-cborbonm Jul 29, 2026
256d063
restore terminating process by default, and return status otherwise
Jul 29, 2026
8e1be8e
Merge branch 'fix-1186' of https://github.com/intersystems/ipm into f…
Jul 29, 2026
9685510
add p prefix to parameter
Jul 29, 2026
9b32ada
add p prefix to parameter
Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- #1178: Add `-password-env` and `-token-env` modifiers to the `repo` command to read the password/token from a named environment variable (secure alternatives to `-password` and `-token`).

### Changed
- #1186: Change %IPM.Main:ShellScript() to return a status.

### Fixed
- #1207: Zero-byte files are now supported in IPM modules

Expand Down
7 changes: 5 additions & 2 deletions src/cls/IPM/Main.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4073,7 +4073,8 @@ ClassMethod History(ByRef pCommandInfo)
ClassMethod ShellScript(
pCommand As %String,
pOutputLogFile As %String = "",
pAppendToLog As %Boolean = 0)
pAppendToLog As %Boolean = 0,
pTerminateOnError As %Boolean = 1) As %Status
{
set tSC = $$$OK
set tFileOpen = 0
Expand Down Expand Up @@ -4105,10 +4106,12 @@ ClassMethod ShellScript(
close pOutputLogFile
}

Comment thread
isc-kiyer marked this conversation as resolved.
if $$$ISERR(tSC) {
if (pTerminateOnError && $$$ISERR(tSC)) {
// Set ERRORLEVEL to 1
do $system.Process.Terminate(,1)
}

return tSC
}

ClassMethod DisplayModules(
Expand Down
Loading