Fix SpyMessage attribute deletion crashes - #252
Open
drebbe-intrepid wants to merge 1 commit into
Open
drebbe-intrepid wants to merge 1 commit into
drebbe-intrepid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting
Data,AckBytes,Header, orExtraDataPtron either message type could crash Python because the shared setter inspected a null deletion value. Route deletion through the generic attribute handler before custom conversion or storage changes, preserving normal descriptor errors.Add 24 subprocess cases covering all six custom setter branches on SpyMessage and SpyMessageJ1850, both unset and populated. Check rejected deletion preserves the payload, lengths and flags, and allows subsequent buffer replacement and destruction.
Validation: Windows x64, CPython 3.14.5; rebuilt native extension; full suite 54 passed. Against the original extension, the new tests reproduced 16 access violations (3221225477); the eight numeric-field cases already passed. No hardware used.
Fixes #237