Fix ignored device settings type override - #253
Open
drebbe-intrepid wants to merge 2 commits into
Open
drebbe-intrepid wants to merge 2 commits into
drebbe-intrepid wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244
get_device_settings(device, device_type)skipped discovery but passed a zero settings type to the native library. Assign the supplied override before requesting settings, and reject values outside the header's settings-type range while preserving-1discovery.Hardware-free mock-library regression tests cover explicit overrides (including both range boundaries), omitted and explicit discovery, invalid/overflowing values, native failures, and settings size/vnet forwarding. Each case uses a subprocess to isolate the global library override.
Validation: Windows x64 / CPython 3.14.5,
python setup.py build; original code fails 3 of 9 new tests; fixed full suite passes all 39 tests;git diff --checkpasses. No hardware accessed. Independent critic and builder agreed before publication. Hardware validation and final CI acceptance remain with the coordinator.Final reviewed commit:
8aa997afc5df533f5b17bd5ea294365151d8f106. Critic/root/critic244: "I agree with the revised final diff. No blocking findings." Builder also explicitly agrees. Critic independently passed all 9 regression tests; revised full suite passed all 39 tests. The i386 mock DLL's undecorated stdcall aliases were verified from its export table; x86 runtime was not tested. Compile/link and regression subprocess calls have timeouts.