Validate transmit message types before native access - #255
Open
drebbe-intrepid wants to merge 2 commits into
Open
drebbe-intrepid wants to merge 2 commits into
drebbe-intrepid wants to merge 2 commits into
Conversation
Reject unsupported objects before reading native message fields or transmitting any part of a batch. Preserve both supported message layouts and cover validation with a hardware-free native stub.
Shared None counts include device handle leaks and interpreter bookkeeping. Measure private rejected inputs, batch containers, and valid neighbors over repeated calls while retaining the full type-rejection matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239
Reject unsupported scalar messages and tuple elements with TypeError before taking native pointers or transmitting any part of a batch. SpyMessage and SpyMessageJ1850 inputs remain supported.
Validation: the new regression failed against the original extension (None was accepted). Rebuilt on Windows x64 with CPython 3.12.10: all 31 tests pass. A native mock verifies zero calls for 35 invalid scalar/batch combinations, successful transmission for both supported types, network IDs, empty batches, and native failure propagation. No hardware was accessed.
Independent critic /root/critic239 explicitly agreed with the final diff and independently passed the regression test. Builder agreement recorded before commit e56291f. CI and hardware acceptance remain with the parent coordinator; do not merge as part of this task.