Fix radio message argument parsing crash - #258
Open
drebbe-intrepid wants to merge 1 commit into
Open
drebbe-intrepid wants to merge 1 commit into
drebbe-intrepid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238.
create_neovi_radio_message()could read past its keyword array and crash Python. Terminate the array with NULL and match the sevenbparser destinations tounsigned char, preserving byte-range validation and existing message encoding.Add 26 hardware-independent subprocess regression cases covering defaults, all keywords, positional arguments, the last keyword alone, unknown keywords, and negative/overflow/non-integer relay and LED values. Windows crash dialogs are suppressed in child processes.
Validation:
/root/critic_238: 26 regression tests passed; explicitly agreed with the final diff. Builder explicitly agrees.No device access performed. Parent coordinator retains CI acceptance, hardware testing, integration and merge.