Skip to content

Validate combined fixes for issues 237–249 - #263

Draft
drebbe-intrepid wants to merge 34 commits into
masterfrom
codex/integration-237-249
Draft

drebbe-intrepid wants to merge 34 commits into
masterfrom
codex/integration-237-249

Conversation

@drebbe-intrepid

@drebbe-intrepid drebbe-intrepid commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Validates the combined fixes from #250#262 before their individual merges. This draft is an integration check; the individual PRs remain the merge units.

All13 issue builders and their critics agreed on final changes. An independent aggregate critic agreed with commit 24fa8ec, including the handle-ownership and payload-getter conflict resolutions.

Validation:

  • Windows CPython3.14.5:232 tests passed,4 internal-only load_readbin skips; independently repeated by aggregate critic.
  • 2,198 C/ctypes size, offset and enum comparisons:zero mismatches.
  • Two consecutive forced in-place builds passed.
  • FIRE3 and RAD-Jupiter:repeated open/close, live-reopen rejection, firmware reads, settings reads and explicit settings-type reads passed with automatic firmware updates disabled.
  • get_device_status returns the same native failure on original and combined builds; local icsneo40.dll version is3.26.3.16.

Awaiting all relevant current-head CI. No fixes have been merged yet.

Reject already-open devices before a second native open. Correct capsule update status and release newly opened handles if Python assignment fails.
Reject unsupported objects before reading native message fields or transmitting any part of a batch. Preserve both supported message layouts and cover validation with a hardware-free native stub.
Track payload capacity independently of mutable wire lengths to prevent heap overreads. Validate length changes, reads, and native writes; preserve DLL-owned buffers and handle reentrant integer conversions safely.

Fixes #240
…ce-equality', 'codex/fix-237-message-deletion', 'codex/fix-238-radio-keywords', 'codex/fix-239-transmit-types', 'codex/fix-241-reflash-callback' and 'codex/fix-244-settings-override' into codex/integration-237-249
Write normalized native scalar fields directly and dispatch deletion before snapshots. Restore state before constructing errors so callback-driven payload replacement cannot resurrect freed pointers.
@drebbe-intrepid drebbe-intrepid changed the title Validate combined fixes for issues237–249 Validate combined fixes for issues 237–249 Sep 16, 2026
Shared None counts include device handle leaks and interpreter bookkeeping. Measure private rejected inputs, batch containers, and valid neighbors over repeated calls while retaining the full type-rejection matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant