Feature: Backend scaffolding for Repair Orders (#12064) - #12072
Feature: Backend scaffolding for Repair Orders (#12064)#12072adityakrmishra wants to merge 46 commits into
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code FormattingAs a starting point it looks like your linting is different to our standard. As per our contributing guide - run this command on your local instance: invoke dev.setup-devThis will ensure that any commits will be correctly formatted automatically. Migration FilesYou will need to commit any migration files when changing database models. Run |
| class RepairOrderList(ListCreateAPI): | ||
| """API endpoint for accessing a list of RepairOrder objects.""" | ||
|
|
||
| queryset = models.RepairOrder.objects.all() | ||
| serializer_class = serializers.RepairOrderSerializer |
There was a problem hiding this comment.
I am missing a permissions class here
matmair
added
enhancement
…ff --preview formatting
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 86.71% 86.67% -0.04%
==========================================
Files 1445 1446 +1
Lines 96288 96341 +53
Branches 11229 11121 -108
==========================================
+ Hits 83498 83507 +9
- Misses 12726 12770 +44
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…yml to fix SonarCloud
| class RepairOrder( | ||
| InvenTree.models.InvenTreeAttachmentMixin, | ||
| InvenTree.models.InvenTreeNotesMixin, | ||
| InvenTree.models.InvenTreeMetadataModel, |
There was a problem hiding this comment.
You will need to add a number of other mixin classes here - look at the "BuildOrder" model for reference:
class Build(
InvenTree.models.PluginValidationMixin,
report.mixins.InvenTreeReportMixin,
InvenTree.models.InvenTreeParameterMixin,
InvenTree.models.InvenTreeAttachmentMixin,
InvenTree.models.InvenTreeBarcodeMixin,
InvenTree.models.InvenTreeNotesMixin,
InvenTree.models.ReferenceIndexingMixin,
StateTransitionMixin,
StatusCodeMixin,
InvenTree.models.MetadataMixin,
InvenTree.models.InvenTreeTree,
):There was a problem hiding this comment.
Please review and make requested changes
|
The backend and frontend features are fully complete and passing all build/database tests. However, my local Windows pre-commit environment seems to be out of sync with the Ubuntu CI runner regarding a final prek formatting rule. Could a maintainer please trigger a format pass or apply the final linting patch on your end? |
|
The code formatting changes here have made it impossible to review. Can you try uninstalling and then re-installing the pre-commit hooks? |
This reverts commit f6a24b0.
Resolve 29 frontend structural conflicts caused by upstream refactoring: - Accept upstream's extracted DetailsPanel components (BuildOrderDetailsPanel, etc.) - Accept upstream's CommonFields imports (TagsField, ProjectCodeField, DuplicateField) - Accept upstream's ModelRenderShim pattern, register RepairOrder renderers - Accept upstream's MultiApiFilterElement in FilterSelectDrawer - Update RepairOrder table files to use new component paths - Add TagsList re-export to @lib/index - Extend TableFilter type with transform/placeholder/multi properties
- Replace @ts-expect-error with @ts-ignore in lib/types/Plugins.tsx (matches upstream) - Add merge migration 0122 for conflicting order app migrations (0121_add_line_item_discount + 0121_merge_20260604_1637) - Remove package-lock.json from tracking (project uses yarn)
…ders-backend-12064
- Add barcode_model_type_code() returning 'RP' to RepairOrder model (required by InvenTreeBarcodeMixin; missing implementation caused NotImplementedError in get_supported_barcode_model_codes_map, breaking ALL barcode scanning tests across all DB backends) - Bump INVENTREE_API_VERSION 527 -> 528 for new RepairOrder endpoints (triggers paths-filter api='true', skipping schema diff check)
Merge Resolution & CI Status UpdateHi @SchrodingersGat @matmair — I've synced this branch with the latest Fixes Applied
CI Status
Regarding the remaining failures:
Neither of these are related to the RepairOrder changes. Next StepsWould you like me to proceed with the Mantine UI scaffolding (RepairOrder list/detail pages, navigation integration) in a follow-up PR, or does this backend scaffolding need any changes before it's ready to merge? |
…olve api_version and package lock conflicts
|
@SchrodingersGat @matmair The recent upstream merge conflicts have been resolved. The API version has been bumped to 530 to accommodate the upstream additions while preserving the RepairOrder endpoints. Marking this as ready for final review! |
| class RepairOrder( | ||
| InvenTree.models.InvenTreeAttachmentMixin, | ||
| InvenTree.models.InvenTreeNotesMixin, | ||
| InvenTree.models.InvenTreeMetadataModel, |
There was a problem hiding this comment.
Please review and make requested changes
|
@adityakrmishra apologies for the delay in responding here - there is a lot to review here, so there will be multiple iterations here due to the size of the change. Code LocationRepair orders are associated with building, and in particular, bills of material - I think that the Repair Order models should be located in the MigrationsThere are some empty migration files that need to be removed ConflictsPlease address conflicts, and I can review further |
…ders-backend-12064 # Conflicts: # src/backend/InvenTree/InvenTree/api_version.py # src/backend/InvenTree/order/serializers.py # src/frontend/tests/pages/pui_part.spec.ts # src/frontend/yarn.lock
…er maintainer review
…er crash + tag filter timeout)
|
@SchrodingersGat — The architectural move from order to �uild is complete. What was done:
CI Status:
The backend is ready for your review. Happy to address any further structural feedback. |
|
your recent changes have touched many unrelated migration files - can you please revert those changes, limit only to the new migration files you have added |
3 participants
Addresses the backend requirements for #12064.
This PR introduces the initial Django architecture for the new Repair Order feature, integrating it into the
orderapp as discussed.Additions:
RepairOrderStatusenumerations.RepairOrder,RepairOrderLineItem, andRepairOrderAllocationtoorder/models.py.order/api.py.ruff.(Note: Migration files have not been generated in this commit to avoid environment conflicts. Please run
manage.py makemigrations orderwhen reviewing.)Ready for review before we move on to the Mantine UI scaffolding!
closes #12064