Repository navigation
ci: tag the release commit and push the appcast last - #152
Merged
Merged
Conversation
Make the release commit (appcast, version, archived notes) before tagging and tag that commit, so the tagged source reports the version it shipped as. Push it to main only after the release exists, since the appcast links to the release's dmg. Abort a conflicting rebase with a clear error, and stop rebasing after the last push attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the tag point at the release commit, so checking out
vX.Y.Zbuilds the version it shipped as and includes its archived notes. Before, the tag pointed at the commit before the bump.New order at the end of the 🚀 Release workflow:
project.pbxproj, archives the notes, and commits all of it locally. Nothing is pushed yet.Unlike PeekPreview (itsjoshpark/PeekPreview#11) and AudioBalance (itsjoshpark/AudioBalance#7), main is still pushed last here. The appcast links to
releases/download/vX.Y.Z/…dmg. Pushing it before the release exists would offer Sparkle users a download that doesn't exist yet, and a broken update if the release step then failed.Also:
If a rebase was needed, main gets a copy of the tagged commit with the same changes rather than the tagged commit itself.