Skip to content

Autodetect unsafe allocations metadata for native images#2883

Open
riccardobl wants to merge 1 commit into
jMonkeyEngine:masterfrom
riccardobl:unsafeallocmeta
Open

Autodetect unsafe allocations metadata for native images#2883
riccardobl wants to merge 1 commit into
jMonkeyEngine:masterfrom
riccardobl:unsafeallocmeta

Conversation

@riccardobl

Copy link
Copy Markdown
Member

This extends the native image plugin to generate metadata for detected patterns of unsafe allocations in jme apps (currently only used by SafeArrayList in the engine) and to allow the dev to whitelist custom classes for this scope.

The bytecode parsing logic was made by gpt 5.5

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for detecting and configuring unsafe allocations in the JMonkeyEngine Native Image Gradle plugin. It adds an allowUnsafeAllocation property to the @PreserveReflection annotation, implements bytecode analysis to automatically detect constructions of unsafe allocation containers (such as SafeArrayList), and provides configuration options to explicitly define unsafe allocated types and container types. There are no review comments, so no additional feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant