Fix --dev failing config validation - #139
Merged
Merged
Conversation
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
jR4dh3y
approved these changes
Oct 1, 2026
jR4dh3y
added a commit
that referenced
this pull request
Oct 1, 2026
* Fix auto_discover mounts being dropped at startup (#131) * Fix auto_discover mounts being dropped at startup Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Make the auto_discover test pick a mounted directory and check it is returned Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Make chunk_size_mb control browser upload chunks (#132) * Make chunk_size_mb control browser upload chunks Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Share one chunk size request across upload workers and respect cancel Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Resolve virtual paths in one place (#133) Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Parse WebSocket and job data at the boundary (#134) * Parse WebSocket and job data at the boundary Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Validate job progress range, add parser tests, log rejected frames briefly Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Move frontend state to runes and split the browse page (#136) * Migrate jobs and websocket stores to runes Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Migrate settings store to runes and split out appearance helpers Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Migrate auth store to runes Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Split the browse page into composables Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Keep the WebSocket reconnect backoff when connect runs in an effect Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Fix the auth API docs, drop stale comments, add AGENTS.md (#137) * Fix the auth API docs, drop stale spec comments, add AGENTS.md Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Add the frontend test command to AGENTS.md Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Correct the logout docs and scope the path rule Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Fix --dev failing config validation (#139) * Fix --dev failing config validation Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Isolate the dev credentials test from inherited BoxBox settings Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Test the WebSocket reconnect backoff (#138) * Test the WebSocket reconnect backoff Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Keep the connection mode on WebSocket retries and test the attempt limit Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Fix browsing discovered mount points Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> * Skip inaccessible auto-discovered mounts Co-authored-by: Radhey Kalra <radheykalra901@gmail.com> --------- Co-authored-by: usehoplite[bot] <288093033+usehoplite[bot]@users.noreply.github.com> Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
boxbox --dev, the documented way to run locally without logging in, exits at startup:--devcreates a placeholder user so that config validation passes, and it hashed that password withbcrypt.MinCost(4). Validation only accepts hashes of cost 10 or more (bcrypt.DefaultCost). It fails onmasterand onstaging/main, andbun run dev:testanddocs/development.mdboth depend on it.Change
bcrypt.DefaultCost. Startup takes about 50 ms longer.main()intosetDevCredentials()incmd/server/devmode.go, so a test can call it.devmode_test.go, which sets the dev credentials and loads a config through the realconfig.Load.Verification
BOXBOX_*,FM_*andCONFIG_PATHvariable first and restores them afterwards, so a developer's own settings cannot change the result. WithBOXBOX_TRUSTED_PROXIES=proxy.localset, it fails without that step and passes with it.password for user "dev" must be a bcrypt hash) and passes with the fix.--devand a config that sayshost: 0.0.0.0. It loggedDEVELOPMENT MODE: authentication disabled; listening on loopback onlyand bound127.0.0.1:18096.GET /api/v1/files/list/mediareturned 200 with no token. In a real browser,/opened/browsewith the folder listing and no login, and there were no page errors.go vet ./cmd/...andgofmtare clean.bun run dev:test(scripts/local-test.ts), and--devon non-Linux.Targets
staging/main.Written by anthropic/claude-sonnet-5-5 in the Hoplite agent harness.