mono - chore: release concurrency group + v5 staged publishing docs - #2124
Merged
Merged
Conversation
Follow-up to the v5 branch's move to npm staged publishing (#2119): - release.yaml: add `concurrency: { group: release, cancel-in-progress: false }`. The v5 branch's release workflow uses the same group, so the two release lines never stage at the same time. - DEFENSE_IN_DEPTH.md §5: record that the v5 line stages through the same `release.yaml` / `release` environment trusted publisher (manual dispatch only), and add the open manual item for `@keyv/serialize`, which exists only on v5 and is not covered by main's trusted-publisher setup. - versioning.md: short "How releases are published" section (staged publishing + provenance on both lines; v6 from a GitHub Release, v5 by a manual run from the `v5` branch; the optional `v5-YYYY-MM-DD` GitHub Release is notes only). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WMpisqNVgPSHdo5CdGwwSN
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2124 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 5281 5281
Branches 857 863 +6
=========================================
Hits 5281 5281 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca9598408e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Documents how both lines release: staged publishing with OIDC trusted publishing and provenance on main (GitHub Release trigger, synced versions) and on the v5 branch (manual workflow_dispatch from v5, independent versions, only packages ahead of npm are staged), plus how staged versions are approved with 2FA. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WMpisqNVgPSHdo5CdGwwSN
2 tasks done
…on main Review follow-ups: - The release concurrency group sets `queue: max` so every queued release stays pending in FIFO order instead of GitHub's default single pending run, where a newly queued release cancels the one already waiting. - The publish job now refuses a `release` event whose tagged commit is not on main (full-history checkout + `git merge-base --is-ancestor`). The workflow file that runs for a GitHub Release is the one at the tagged commit, so a tag on the v5 branch runs v5's dispatch-only workflow rather than this one; the guard makes the "a v5-YYYY-MM-DD release-notes tag publishes nothing" claim hold regardless. - CONTRIBUTING.md, versioning.md and DEFENSE_IN_DEPTH.md updated to match, including the documented new-package exception (a brand-new package cannot be staged; a maintainer creates it by hand once, then adds its stage-only trusted publisher). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WMpisqNVgPSHdo5CdGwwSN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
concurrencyblock only; no runtime code.What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore / docs — the small
mainfollow-up to #2119, which moves the v5 maintenance line to npm staged publishing with provenance. Nothing about how v6 is released changes.Changes
.github/workflows/release.yaml: addconcurrency: { group: release, cancel-in-progress: false }. The v5 branch's release workflow already uses this group, so the two release lines can never stage at the same time (the v5 script re-verifies the registry before each stage, but not overlapping at all is simpler).CONTRIBUTING.md: new Release Process section covering both lines side by side — how v6 is released frommain(release PR +pnpm version:sync, GitHub Release triggers the workflow), how v5 is released from thev5branch (release PR with per-package bumps, manual Run workflow fromv5, only packages ahead of npm are staged), and how staged versions are approved with 2FA (pnpm stage list/view/approve/reject, in dependency order, promptly). The same section lands on thev5branch in mono - feat: stage v5 releases to npm with provenance #2119.DEFENSE_IN_DEPTH.md§5: record that the v5 line stages through the samerelease.yaml/releaseenvironment stage-only trusted publisher (manualworkflow_dispatchfromv5only; no direct publish), and add the open manual item for@keyv/serialize— that package exists only on v5, so main's trusted-publisher setup does not cover it.website/site/docs/migration/versioning.md: a short "How releases are published" section — staged publishing + provenance on both lines; v6 from a GitHub Release, v5 by a manual run from thev5branch (only packages ahead of npm are staged); the optionalv5-YYYY-MM-DDGitHub Release is release notes only.Why nothing else is needed on
mainfor v5The Actions "Run workflow" button is listed because main's
release.yamlhasworkflow_dispatch; choosing "Use workflow from: v5" runs the v5 branch's ownrelease.yaml. Both files share the filename and thereleaseenvironment, so one npm trusted-publisher configuration covers both lines — nov5-release.yamlon main.🤖 Generated with Claude Code
https://claude.ai/code/session_01WMpisqNVgPSHdo5CdGwwSN