Conversation
For a component precision of 32, the expressions 1 << (prec - 1) and 1 << prec in bitstoint() invoke undefined behavior on 32-bit int, and JAS_ONES(prec) has the same problem. Compute the masks and the sign extension in uint_fast64_t/jas_seqent_t instead. inttobits() gets the same mask fix since JAS_ONES(32) is equally affected. Fixes jasper-software#415.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #415 —
bitstoint()invokes undefined behavior for a component precision of 32:1 << (prec - 1)=1 << 31overflows into the sign bit of a 32-bitint1 << prec=1 << 32has an out-of-range shift exponentv - (1 << prec)then wraps in unsigned 32-bit, producing a wrong sign extension, andJAS_ONES(32)=(1 << 32) - 1has the same UB — also reached viainttobits()Fix
JAS_POW2_X(uint_fast64_t, prec) - 1(defined forprec <= 32)JAS_POW2_X(uint_fast32_t, prec - 1)(bit 31 is fine in unsigned)v - 2^precinjas_seqent_t(64-bit), giving the mathematically correct negative resultTesting
Reproduced with the PoC attached to #415 under UBSan:
After the patch: no sanitizer report, decode fails gracefully on the malformed input.