ci: route mbx caching by runner provider - #1369
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe mbx action now uses platform-specific mise setup, installs mbx for all backends, and configures server or local-store environment variables. Workflows select the server backend where required and grant OIDC permissions. The Changesmbx store setup
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🟡 Moderate · up to This change routes untrusted CI jobs through a shared remote cache using OIDC. The PR depends on server-side controls to prevent untrusted writes and cross-namespace access, but those controls are not verified here; the change is therefore not fully merge-ready until that authorization behavior is confirmed or explicitly accepted. Sequence Diagram(s)sequenceDiagram
participant WorkflowJob
participant mbxAction
participant mise
participant mbx
WorkflowJob->>mbxAction: invoke with backend
mbxAction->>mise: configure runner-specific directories
mbxAction->>mise: install and reshim mbx
mise-->>mbxAction: provide installed tool path
mbxAction->>mbx: emit backend environment variables
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e589b40 to
a663276
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e81c1db. Configure here.
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|

Route mbx storage according to the runner provider.
https://cache.jdx.devwith GitHub OIDC.mainpushes may publish.Validation: actionlint; git diff --check
AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Medium Risk
Changes CI cache authentication and removes GitHub Actions cache mirroring; misconfigured OIDC or env could slow builds or affect fork vs trusted cache access, but scope is limited to CI tooling.
Overview
Replaces the
mr-boxington-action+ GitHub Actions cache mirror with a single composite action that installs mr-boxington 1.5.0 via mise and setsMBX_*env for either Namespace local storage or the remote cache athttps://cache.jdx.dev.Trusted Namespace jobs still use
backend: local; GitHub-hosted jobs usebackend: server(renamed fromgithub). Themirror-github-cacheinput and main-branch mirror restore step are removed. Server mode wiresMBX_REMOTE_URL, namespace, and OIDC audience whenACTIONS_ID_TOKEN_REQUEST_URLis present; otherwise it logs a notice and relies on public read-only access.Workflow updates:
test.ymlgrantsid-token: writeon the trusted path;test-impl.ymldrops the untrusted OIDC assertion and stops passingmirror-github-cache. The mbx action also adds Windows mise paths underrunner.tool_cacheso install works onwindows-latest.Reviewed by Cursor Bugbot for commit 7f7d88f. Bugbot is set up for automated code reviews on this repo. Configure here.