gln/out-of-diff-fixes-xtuy - #414
Merged
Merged
Conversation
Clicking an out-of-diff comment's file link in the timeline focuses the diff at its line, but the line sits inside a collapsed skip block, so the code and the comment stayed hidden. The diff view now expands the skip block containing a focused line (same flow as search-match jumps), with focusFirstLine off so the target keeps focus and the scroll lands on the comment once the rows exist.
Thread previews in the conversations sidebar rendered the raw body with the position marker and blob permalink. Out-of-diff comments are stripped to their user text there like everywhere else.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc4e930bfix: hide out-of-diff markers in the conversations sidebarThread previews in the conversations sidebar rendered the raw body with
the position marker and blob permalink. Out-of-diff comments are
stripped to their user text there like everywhere else.
4dcd2a83feat: unfold skip blocks when navigating to out-of-diff commentsClicking an out-of-diff comment's file link in the timeline focuses the
diff at its line, but the line sits inside a collapsed skip block, so
the code and the comment stayed hidden. The diff view now expands the
skip block containing a focused line (same flow as search-match jumps),
with focusFirstLine off so the target keeps focus and the scroll lands
on the comment once the rows exist.