gln/pr-notifications-and-reviews-yzms - #418
Merged
Merged
Conversation
The reviewer list (requested users and teams) comes from the PR object, which the submit flow never refreshed - dismissed review requests lingered until a reload. The submission refetch now includes the PR and syncs it into the store so the reviewer list recomputes live. This also covers the team-re-request workflow for second reviews.
The hourglass next to a stale reviewer badge is now a button that navigates the diff to the interdiff between that review's commit and the current head, so the reviewer sees exactly the changes since their review. Wired in the reviewer list and the merge box; the tooltip says 'click to view' when clickable.
GitHub keeps the conversation unread after the author pushes (own activity never notifies on github.com, but isReadByViewer stays false), so every push to your own PR fired a notification. The activity enrichment now carries the PR author, and both poll loops skip notifications, merge notices and hints for the viewer's own PRs. Data refresh and bookkeeping still run so the views stay current.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
469f0dfafix: suppress notifications for the viewer's own PRsGitHub keeps the conversation unread after the author pushes (own
activity never notifies on github.com, but isReadByViewer stays false),
so every push to your own PR fired a notification. The activity
enrichment now carries the PR author, and both poll loops skip
notifications, merge notices and hints for the viewer's own PRs. Data
refresh and bookkeeping still run so the views stay current.
965e9ca3feat: click the stale hourglass to view the changes since the reviewThe hourglass next to a stale reviewer badge is now a button that
navigates the diff to the interdiff between that review's commit and
the current head, so the reviewer sees exactly the changes since their
review. Wired in the reviewer list and the merge box; the tooltip says
'click to view' when clickable.
2b6aae44fix: refresh the PR object when a review is submittedThe reviewer list (requested users and teams) comes from the PR object,
which the submit flow never refreshed - dismissed review requests
lingered until a reload. The submission refetch now includes the PR and
syncs it into the store so the reviewer list recomputes live. This also
covers the team-re-request workflow for second reviews.