gln/ui-refinements-timestamps-hovercards-xtmt - #421
Merged
Merged
Conversation
Author hover cards were wired into the conversation view, the PR header and mentions, but the diff view rendered bare avatars and logins, so hovering an author in the gutter did nothing. Wrap the avatar and login of each comment, plus the participant avatars on collapsed thread headers, in the same hover card used elsewhere.
Relative times like "1d ago" were plain text, and the few with a hover hint used a native title showing only minutes - so a review header revealed its time while the comments under it revealed nothing. Add a shared TimeAgo component that shows the exact, second-precision timestamp on hover and use it for every timestamp in the review flow: diff comments, reviews and their comments, issue comments, commits, timeline events and the conversations sidebar.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8efab353feat: show the exact time when hovering a relative timestampRelative times like "1d ago" were plain text, and the few with a hover
hint used a native title showing only minutes - so a review header
revealed its time while the comments under it revealed nothing. Add a
shared TimeAgo component that shows the exact, second-precision
timestamp on hover and use it for every timestamp in the review flow:
diff comments, reviews and their comments, issue comments, commits,
timeline events and the conversations sidebar.
b1e112c4fix: show hover cards for comment authors in the diff viewAuthor hover cards were wired into the conversation view, the PR header
and mentions, but the diff view rendered bare avatars and logins, so
hovering an author in the gutter did nothing. Wrap the avatar and login
of each comment, plus the participant avatars on collapsed thread
headers, in the same hover card used elsewhere.