fix: improve bulk record update failure states#1850
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves bulk record update reliability by preventing oversized Salesforce re-fetch queries, improving client-side error recovery (so users can retry preview), and upgrading error telemetry/logging for troubleshooting.
Changes:
- Chunk
WHERE Id IN (...)re-fetch queries by resulting SOQL length (vs fixed Id count) to avoid Salesforce query-URL length failures. - Treat preview-load failures as recoverable (retryable) and attach more context to error tracking.
- Increase server-side error log visibility for 5xx responses.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/shared/ui-core/src/mass-update-records/mass-update-records.utils.tsx | Adds query-length-bounded chunking for Id IN (...) queries used during record re-fetch. |
| libs/shared/ui-core/src/mass-update-records/tests/mass-update-records.utils.spec.ts | Updates test to assert each generated query stays under the length limit. |
| libs/features/query/src/QueryResults/BulkUpdateFromQuery/BulkUpdateFromQueryModal.tsx | Makes preview failures recoverable (retryable) and logs richer context via tracker. |
| apps/api/src/app/utils/response.handlers.ts | Logs 5xx user-facing errors at warn level instead of debug. |
paustint
force-pushed
the
fix/improve-bulk-update-failure-states
branch
from
July 9, 2026 13:27
e21272f to
941e1e8
Compare
paustint
force-pushed
the
fix/improve-bulk-update-failure-states
branch
from
July 14, 2026 21:09
941e1e8 to
b5a1ba4
Compare
paustint
force-pushed
the
fix/improve-bulk-update-failure-states
branch
from
July 16, 2026 01:51
b5a1ba4 to
2f01f3e
Compare
paustint
force-pushed
the
fix/improve-bulk-update-failure-states
branch
from
July 16, 2026 02:04
2f01f3e to
a30239d
Compare
Ensure queries are not too large log the error message and track additional context for ease of troubleshooting ensure user can retry and is not blocked if Salesforce returns an error
paustint
force-pushed
the
fix/improve-bulk-update-failure-states
branch
from
July 16, 2026 13:30
a30239d to
c211ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure queries are not too large
log the error message and track additional context for ease of troubleshooting
ensure user can retry and is not blocked if Salesforce returns an error