Remove leftover MARKETING_URL plumbing after site/ deletion - #85
Merged
Merged
Conversation
Nothing in web/ reads deploymentConfig.marketingUrl. Drop the unread config field, Amplify env, CDK context, CLI CONTEXT_KEYS / HOSTED_KEYS, and tests that still expected the marketing origin. Co-authored-by: Jaime Ginorio <jaime.ginorio@finditpr.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site/is gone (#70) and nothing inweb/readsdeploymentConfig.marketingUrl. This PR strips the leftover env plumbing — not another site deletion.marketingUrlfromweb/lib/deployment/config.tsMARKETING_URLfrom CDK Amplify envMARKETING_URLfrom CLICONTEXT_KEYS/HOSTED_KEYSamplify.ymlenv grepMARKETING_URLis ignored; hostedAPP_URL/APP_MODEandBILLING_ENABLEDstayKeep
APP_URL/ hostedAPP_MODE(Allow hosted APP_MODE to keep context101.dev public URLs #81)BILLING_ENABLED/ hosted plumbing that is still intentionalLeave alone
@context101/uifonts fold, shadcn depTest plan
npm --prefix packages/cli test— 281/281 pass (includescdk-invoke.test.jsleftoverMARKETING_URLignored; hostedAPP_URLstill forwarded)stack-synth.test.ts— 2/2 pass (hostedAPP_MODEkeepsAPP_URL/BILLING_ENABLED;MARKETING_URLcontext is not Amplify env)MARKETING_URL/marketingUrlremain only in those ignore assertions