jmix-add-entity-event-listener: fix the isLoaded guard and cover a soft-deleted reference target - #125
Draft
glebfox wants to merge 1 commit into
Draft
jmix-add-entity-event-listener: fix the isLoaded guard and cover a soft-deleted reference target#125glebfox wants to merge 1 commit into
glebfox wants to merge 1 commit into
Conversation
…ft-deleted reference target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119.
Drafted from a field report while the problem was fresh, by the agent that hit it. It is unreviewed: treat the wording as a starting point, not a proposal to merge as-is.
Change
Two additions to "Reading a reference you nevertheless need":
isLoaded(...) && value != null, with a paragraph explaining why —EntityStates.isLoadedreports every attribute of aDataManager.getReferenceinstance as loaded, so the plain guard takes the wrong branch and the getter returns null.PersistenceHints.SOFT_DELETIONfalse.