jmix-create-entity: say that a length of 255 is omitted, not written - #133
Draft
glebfox wants to merge 1 commit into
Draft
jmix-create-entity: say that a length of 255 is omitted, not written#133glebfox wants to merge 1 commit into
glebfox wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131.
Drafted from a field report while the problem was fresh, by the agent that hit it. It is unreviewed: treat the wording as a starting point, not a proposal to merge as-is.
Change
Two edits to one file. Step 6 gains a line saying a
lengthof 255 is@Column's own default and is omitted. The Constraint Audit'slengthbullet gains the reason and the asymmetry: the audit compares the effective length rather than the presence of the attribute, because SQL has no 255 default so the changelog always spellsvarchar(255);precision/scaledefault to 0 and so are always written on both sides.