Skip to content

monitor-stack: route unexpected failures through the troubleshooter (#214) - #226

Merged
jodavis merged 1 commit into
dev/claude/Issue-215from
dev/claude/Issue-214
Aug 31, 2026
Merged

monitor-stack: route unexpected failures through the troubleshooter (#214)#226
jodavis merged 1 commit into
dev/claude/Issue-215from
dev/claude/Issue-214

Conversation

@jodavis-claude

@jodavis-claude jodavis-claude commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Work item: watch-stack should use the trhoubleshooter when things go wrong #214monitor-stack's hard-stop points just reported failure in detail and stopped, forcing whatever spawned it (or the user, in watch-stack should not isolate itself #215's now-common direct-invocation case) to absorb the raw diagnosis, instead of following the same troubleshooter pattern workflow-orchestrate/concurrent-orchestrate already use for their own pipeline anomalies.
  • Changes:
    • Every failure that indicates a genuine pipeline bug rather than a usage/precondition issue — a missing feature branch or bottom-of-stack PR, a stack_checkout.py/stack_pr_poll.py/stack_rebase_continue.py script error, a stack_complete cleanup failure, or a fix-pr/resolve-rebase-conflict spawn reporting anything other than successful — now dispatches dev-team:troubleshooter with the epic's own context file, bounded to one retry per occurrence before falling back to a plain hard stop.
    • Step 1's worktree-freshness guard (a documented upstream Claude Code bug, not this plugin's own) and step 2b's own epic-derivation failure (a usage issue, not a pipeline bug) are left as direct hard stops, since neither is something workflow-troubleshoot's fix strategies apply to.
  • Design decisions: The deliberate "unresolved rebase conflict halts the whole epic" path is intentionally not routed through the troubleshooter — a real merge conflict needing human judgment isn't a pipeline bug, so no issue gets filed for it and the existing git rebase --abort + hard-stop behavior is unchanged.
  • Testing completed: python3 -m pytest plugins/dev-team/skills/workflow-orchestrate/scripts — 297 passed (no Python changed by this PR; prose-only change to monitor-stack/SKILL.md).

Closes #214

@github-actions

Copy link
Copy Markdown

build-and-test: Python test results

Status: ✅ Passed

Test log

@jodavis-claude jodavis-claude changed the title dev/claude/Issue 214 monitor-stack: route unexpected failures through the troubleshooter (#214) Aug 27, 2026
@jodavis
jodavis marked this pull request as ready for review August 31, 2026 20:52
…leshooter

monitor-stack's hard-stop points just reported failure in detail and stopped, forcing whatever
spawned it (or the user, in the now-common direct-invocation case from #215) to absorb the raw
diagnosis. Every failure that indicates a genuine pipeline bug rather than a usage/precondition
issue — a missing feature branch or bottom-of-stack PR, a stack_checkout.py/stack_pr_poll.py/
stack_rebase_continue.py script error, a stack_complete cleanup failure, or a fix-pr/
resolve-rebase-conflict spawn reporting anything other than successful — now dispatches
dev-team:troubleshooter with the epic's own context file instead, mirroring the same pattern
workflow-orchestrate and concurrent-orchestrate already use for their own pipeline anomalies.
This keeps the actual debugging investigation, and any bug it files, out of the calling session's
context, and bounds each occurrence to one troubleshooter-applied retry before falling back to a
plain hard stop. Step 1's worktree-freshness guard (a documented upstream Claude Code bug, not
this plugin's own) and step 2b's own epic-derivation failure (a usage issue) are left as direct
hard stops, since neither is something workflow-troubleshoot's fix strategies apply to.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXkXzYacgX31sUpJ3CqSX4
(cherry picked from commit c9343e42557dbac08a848e880b7c4fa215220c94)
@jodavis
jodavis merged commit 63da8d2 into main Aug 31, 2026
3 checks passed
@jodavis
jodavis deleted the dev/claude/Issue-214 branch August 31, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

watch-stack should use the trhoubleshooter when things go wrong

3 participants