Add PR check requiring plugin version bump on plugin-directory changes - #230
Merged
Conversation
Enforces that any PR touching plugins/<name>/ raises that plugin's version in plugin.json before merging to main, catching the "forgot to bump the version" mistake that's currently only prevented by manual discipline. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169tvYH3dirw6Fc1EPRQ3S8
build-and-test: Python test resultsStatus: ✅ Passed Test log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/<name>/must raise that plugin'sversioninplugin.jsonabove the version onmain, or the check fails.plugins/*/(works if more plugins are added later), evaluates every touched plugin independently, and reports all violations in one run.Changes
scripts/check_plugin_versions.py— stdlib-only Python checker (no third-party deps).scripts/test_check_plugin_versions.py— 25 pytest unit tests covering new/deleted plugins, unchanged/lowered versions, invalid semver, multi-plugin PRs..github/workflows/plugin-version-check.yml— triggers on PRs targetingmainonly (not intermediate stacked-PR branches); agatejob skips the rest when noplugins/**files changed;check-versionsruns the checker;test-scriptruns the unit tests unconditionally.Test plan
python3 -m pytest scripts/test_check_plugin_versions.py -v— 25/25 passing.github/workflows/andscripts/, notplugins/, socheck-versionsshould be gated off and onlytest-scriptshould run)🤖 Generated with Claude Code
https://claude.ai/code/session_0169tvYH3dirw6Fc1EPRQ3S8