Skip to content

ADR-394: Delete add-to-spec command, superseded by revise mode - #245

Draft
jodavis-claude wants to merge 1 commit into
dev/claude/ADR-393from
dev/claude/ADR-394
Draft

ADR-394: Delete add-to-spec command, superseded by revise mode#245
jodavis-claude wants to merge 1 commit into
dev/claude/ADR-393from
dev/claude/ADR-394

Conversation

@jodavis-claude

Copy link
Copy Markdown
Collaborator

Work item: ADR-394 — delete plugins/dev-team/commands/add-to-spec.md, which is superseded by the revise mode being added to write-proposal, write-detailed-design, and write-dev-spec in sibling tasks of this epic (ADR-336, "Proposal / Detailed Design split").

Changes:

  • Deleted plugins/dev-team/commands/add-to-spec.md. Confirmed before deletion that no other file in the repo references it by name (aside from _spec_ProposedSkillsBreakdown.md, an out-of-scope historical/lineage doc, left untouched).
  • Bumped plugins/dev-team/.claude-plugin/plugin.json "version" from 1.4.0 to 1.4.1 (patch bump), required by the plugin-version-check CI gate since this diff touches a file under plugins/dev-team/.

Design decisions:

  • add-to-spec existed for one narrow case — appending a single bounded, work-item-shaped addition to an existing document. All three write-* commands are gaining a revise mode elsewhere in this epic that strictly subsumes that case, so add-to-spec is removed outright rather than extended to a three-way branch.
  • Scope is deliberately just the deletion, not a stale-reference sweep. Stale cross-references to renamed/removed things are explicitly deferred to ADR-395, which depends on this deletion happening first.
  • No E2E/unit tests were added: the diff is a static command-definition file deletion plus a JSON version bump, with no runtime behavior or existing test harness applicable to either.

Testing completed:

  • scripts/validate-build.sh was run as part of the standard validation pipeline (log: ADR-394-validate-20260904T003923.log).
  • No unit or E2E tests apply to this change; verified manually that the exit criterion ("/add-to-spec is no longer a recognized command") is satisfied by the file's absence, since Claude Code recognizes slash commands purely by file presence under a plugin's commands/ directory.

add-to-spec covered one narrow case (appending a bounded addition to an existing document) that the revise mode being added to write-proposal, write-detailed-design, and write-dev-spec elsewhere in this epic strictly subsumes. Bumps plugins/dev-team's plugin.json version (1.4.0 -> 1.4.1) per the plugin-version-check CI gate.

@jodavis-claude jodavis-claude left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — ADR-394: Delete add-to-spec command

Reviewed the diff against the task brief's exit criteria and CONTRIBUTING.md guidelines.

Exit criteria — both met:

  • commands/add-to-spec.md no longer exists — confirmed deleted in the diff.
  • /add-to-spec is no longer a recognized command — Claude Code plugin commands are discovered
    purely by file presence under commands/, so the deletion alone satisfies this. A repo-wide
    grep confirms no other file (README, other commands, scripts, plugin.json) references
    add-to-spec by name, other than the historical lineage doc _spec_ProposedSkillsBreakdown.md,
    which is correctly left untouched per the brief's stated scope.

plugin.json version bump (1.4.0 → 1.4.1): Verified against the actual PR base branch
(dev/claude/ADR-393), whose plugin.json was indeed 1.4.0 — the bump to 1.4.1 is a correct
patch increment matching this repo's established convention.

No Priority 1–4 issues found. No correctness/fault-tolerance, security, performance, or
documentation problems — this is a pure file deletion plus a version bump, with no runtime
behavior, so no unit or E2E tests apply (consistent with missing-test-harness policy).

Non-blocking FYI, already flagged by the developer's own Known Ambiguities: the epic's
_spec_ProposalDetailedDesignSplit.md file is not present anywhere in this branch's lineage
(feature/ADR-336-proposal-detailed-design-splitdev/claude/ADR-393dev/claude/ADR-394),
confirming ADR-393 sits outside the epic's gh stack chain used by sibling tasks
(ADR-387→388→389→391→392). This is a pre-existing pipeline/stack-registration inconsistency,
unrelated to this task's own file-deletion scope, and does not block this PR — but the epic owner
should reconcile it before the stack is merged.

Approving — no changes requested.

@jodavis-claude jodavis-claude left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-off review — ADR-394 (PR #245)

No prior review threads were left unresolved — the first-pass review (posted 2026-09-04T00:51:11Z against this same commit 82d7a69) approved the diff with no Priority 1–4 issues and no inline comments.

No commits have been added since that review, so there are no newly-modified files to re-scan. Re-confirmed the diff independently:

  • plugins/dev-team/commands/add-to-spec.md deleted — satisfies both exit criteria (file no longer exists; /add-to-spec no longer discoverable since Claude Code plugin commands are found purely by file presence).
  • plugins/dev-team/.claude-plugin/plugin.json version bumped 1.4.01.4.1, a correct patch increment over the actual base branch (dev/claude/ADR-393) value.

No new Priority 1-4 issues found. Signing off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants