ADR-394: Delete add-to-spec command, superseded by revise mode - #245
ADR-394: Delete add-to-spec command, superseded by revise mode#245jodavis-claude wants to merge 1 commit into
Conversation
add-to-spec covered one narrow case (appending a bounded addition to an existing document) that the revise mode being added to write-proposal, write-detailed-design, and write-dev-spec elsewhere in this epic strictly subsumes. Bumps plugins/dev-team's plugin.json version (1.4.0 -> 1.4.1) per the plugin-version-check CI gate.
jodavis-claude
left a comment
There was a problem hiding this comment.
Review — ADR-394: Delete add-to-spec command
Reviewed the diff against the task brief's exit criteria and CONTRIBUTING.md guidelines.
Exit criteria — both met:
commands/add-to-spec.mdno longer exists — confirmed deleted in the diff./add-to-specis no longer a recognized command — Claude Code plugin commands are discovered
purely by file presence undercommands/, so the deletion alone satisfies this. A repo-wide
grep confirms no other file (README, other commands, scripts, plugin.json) references
add-to-specby name, other than the historical lineage doc_spec_ProposedSkillsBreakdown.md,
which is correctly left untouched per the brief's stated scope.
plugin.json version bump (1.4.0 → 1.4.1): Verified against the actual PR base branch
(dev/claude/ADR-393), whose plugin.json was indeed 1.4.0 — the bump to 1.4.1 is a correct
patch increment matching this repo's established convention.
No Priority 1–4 issues found. No correctness/fault-tolerance, security, performance, or
documentation problems — this is a pure file deletion plus a version bump, with no runtime
behavior, so no unit or E2E tests apply (consistent with missing-test-harness policy).
Non-blocking FYI, already flagged by the developer's own Known Ambiguities: the epic's
_spec_ProposalDetailedDesignSplit.md file is not present anywhere in this branch's lineage
(feature/ADR-336-proposal-detailed-design-split → dev/claude/ADR-393 → dev/claude/ADR-394),
confirming ADR-393 sits outside the epic's gh stack chain used by sibling tasks
(ADR-387→388→389→391→392). This is a pre-existing pipeline/stack-registration inconsistency,
unrelated to this task's own file-deletion scope, and does not block this PR — but the epic owner
should reconcile it before the stack is merged.
Approving — no changes requested.
jodavis-claude
left a comment
There was a problem hiding this comment.
Sign-off review — ADR-394 (PR #245)
No prior review threads were left unresolved — the first-pass review (posted 2026-09-04T00:51:11Z against this same commit 82d7a69) approved the diff with no Priority 1–4 issues and no inline comments.
No commits have been added since that review, so there are no newly-modified files to re-scan. Re-confirmed the diff independently:
plugins/dev-team/commands/add-to-spec.mddeleted — satisfies both exit criteria (file no longer exists;/add-to-specno longer discoverable since Claude Code plugin commands are found purely by file presence).plugins/dev-team/.claude-plugin/plugin.jsonversion bumped1.4.0→1.4.1, a correct patch increment over the actual base branch (dev/claude/ADR-393) value.
No new Priority 1-4 issues found. Signing off.
Work item: ADR-394 — delete
plugins/dev-team/commands/add-to-spec.md, which is superseded by the revise mode being added towrite-proposal,write-detailed-design, andwrite-dev-specin sibling tasks of this epic (ADR-336, "Proposal / Detailed Design split").Changes:
plugins/dev-team/commands/add-to-spec.md. Confirmed before deletion that no other file in the repo references it by name (aside from_spec_ProposedSkillsBreakdown.md, an out-of-scope historical/lineage doc, left untouched).plugins/dev-team/.claude-plugin/plugin.json"version"from1.4.0to1.4.1(patch bump), required by theplugin-version-checkCI gate since this diff touches a file underplugins/dev-team/.Design decisions:
add-to-specexisted for one narrow case — appending a single bounded, work-item-shaped addition to an existing document. All threewrite-*commands are gaining a revise mode elsewhere in this epic that strictly subsumes that case, soadd-to-specis removed outright rather than extended to a three-way branch.Testing completed:
scripts/validate-build.shwas run as part of the standard validation pipeline (log:ADR-394-validate-20260904T003923.log)./add-to-specis no longer a recognized command") is satisfied by the file's absence, since Claude Code recognizes slash commands purely by file presence under a plugin'scommands/directory.