Refactor Analysis#190
Open
itsmohmans wants to merge 28 commits into
Open
Conversation
thread-koder
force-pushed
the
development
branch
3 times, most recently
from
217aa72 to
76f1b90
Compare
- highlight using xlsx over csv
- use table styling in print similar to mobile styling - show all comments when printing - make the default browser printing and the print button's behaviours consistent
itsmohmans
force-pushed
the
refactor/analysis-result
branch
from
827813d to
ac16632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant refactor of the analysis workflow, moving from immediate analysis and result passing to a job-based system. Now, when a user submits text or a file for analysis, an analysis job is created and tracked by its ID. Subsequent result retrieval and downloads are performed using this job ID, for a scalable, paginated, and an async processing, along with a better UX for the user since the results page shows up immediately and shows the analysis processing as it progresses. The frontend and backend have been updated to support this new approach, with several new API endpoints and changes to data flow.
Backend: Job-based analysis and new endpoints
AnalysisQueuesystem to manage analysis jobs, including creation, status tracking using Redis, result pagination, and background processing. New endpoints have been added for job creation, overview, results retrieval, and batch analysis (server/api/analyze/[id]/analyze.post.ts,server/api/analyze/[id]/overview.get.ts,server/api/analyze/[id]/results.get.ts).comment.post.ts,file.post.ts) to create jobs instead of returning immediate results, and updated response formats to return job metadata (analysis ID, total comments) rather than analysis data.Frontend: Data flow and download modal updates
jobIdfor result retrieval and downloads, replacing direct use of analysis data. TheDownloadModal.vueandForm.vuecomponents now handle job IDs and route users to results pages with job IDs in query parameters.Download/export endpoints: Job-based result fetching
job_idfrom the analysis queue, and updated export metadata to include job information and progress. Improved error handling and data formatting for these endpoints.Other improvements
Note: some of this PR description was generated by GitHub Copilot which I've proofread or edited.