UX improvements: error states, loading messages, search, and agent welcome - #282
Open
joreilly wants to merge 2 commits into
Open
UX improvements: error states, loading messages, search, and agent welcome#282joreilly wants to merge 2 commits into
joreilly wants to merge 2 commits into
Conversation
…lcome - Error states with real messages, icons, and retry buttons across Climate, Country detail, and Rankings screens - Contextual loading messages (e.g. "Loading global emissions data...") - Toggleable search bar with sort chips moved above it - Refresh support in CountryListViewModel for retry functionality - Agent welcome screen with suggested prompt chips - Rankings and country rows now show trailing chevron for clickability - Treemap selection feedback with prominent border highlight - Renamed "Share" stat card to "Global Share" for clarity Co-authored-by: Junie <junie@jetbrains.com>
The leadingIcon was changed to a Close button in a previous commit, which resulted in two X buttons when typing text (one on the left and one on the right). - Restore leadingIcon to the standard Search icon - Make trailingIcon (Close X) always visible in search mode so users can exit search even without typing text - Remove unused AnimatedVisibility/fadeIn/fadeOut imports Co-authored-by: Junie <junie@jetbrains.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UX improvements across the app based on recommended changes #1–#4, plus bonus polish that naturally fit during the same pass.
Changes
High Impact
1. Error states with real messages
Text("Error")with proper error state composables showing an error icon, descriptive title, the actual error message, and a "Retry" button2. Loading states with context
3. Toggleable search bar
4. Refresh support
loadCountryData()in CountryListViewModelrefresh()method so error states can trigger a retryMedium Impact (Bonus)
5. Agent welcome screen
6. "Global Share" label
7. Clickable row indicators
KeyboardArrowRightchevron to country rows and ranking rows for consistent clickability8. Treemap selection feedback
Verification
composeApp:compileKotlinJvmbuilds successfully with no errors