Small fixes and refactor document structure/length - #246
Merged
Merged
Conversation
The kitty text sizing protocol makes the 'text' field optional, 'ESC ] 66 ; metadata [ ; text ] BEL/ST', but our pattern required the second ';', so a metadata-only sequence such as '\x1b]66;w=5\x07' went unrecognized. The text group is now optional in both TEXT_SIZING_PATTERN and _SEQUENCE_CLASSIFY. UAX #11 defines ambiguous width as 1 or 2, but values outside that range were honored, so ambiguous_width=5 widened every ambiguous character by five cells. Clamp instead, in wcwidth(), wcswidth(), wcstwidth(), width() and clip(). SequenceTextWrapper now raises ValueError for a width of zero or less, matching stdlib textwrap. This is a behavior change: wrap('女', 0) previously returned ['女'].
The hatchling sdist allowlist includes "/wcwidth/**" and hatchling honors .gitignore, so locally built extension modules were swept into 'python -m build --sdist' output, taking it from 1.4M to 2.7M. The wheel is unaffected: the extension reaches it from build_ext compiling ext_modules, not from source file collection.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1983 1999 +16
Branches 464 467 +3
=========================================
+ Hits 1983 1999 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jquast
changed the title
also a small performance improvement to clamping ambiguous_width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of low-priority fixes discovered while preparing the C11 'libwcwidth' library,
1-2textwrap.wrap()*.soto.gitignore, so that they do not leak in any next sdistFurther, the README.rst file has been refactored into file parts: