Skip to content

bugfix width() value for very long CSI sequences - #272

Merged
jquast merged 1 commit into
masterfrom
jq/bugfix-verylong-csi
Sep 23, 2026
Merged

jquast merged 1 commit into
masterfrom
jq/bugfix-verylong-csi

Conversation

@jquast

@jquast jquast commented Sep 23, 2026

Copy link
Copy Markdown
Owner

A case found when making tests for C11 coverage, about measurement mismatch for very-long 64+ byte
escape sequences

@jquast jquast changed the title bugfix width() value for very-long CSI sequences bugfix width() value for very long CSI sequences Sep 23, 2026
@codspeed

codspeed Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 86.9%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 118 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_width_dense_ansi_control_codes_ignore 408.8 µs 218.7 µs +86.9%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing jq/bugfix-verylong-csi (16adf4f) with master (b3fb5f2)

Open in CodSpeed

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.49%. Comparing base (b3fb5f2) to head (16adf4f).

Files with missing lines Patch % Lines
libwcwidth/src/width.c 78.57% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   87.50%   87.49%   -0.01%     
==========================================
  Files          41       41              
  Lines        5593     5614      +21     
  Branches     1494     1501       +7     
==========================================
+ Hits         4894     4912      +18     
- Misses        323      324       +1     
- Partials      376      378       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

A case found when making C11 coverage, about measurement mismatch for
very-long 64+ byte escape sequences
@jquast
jquast force-pushed the jq/bugfix-verylong-csi branch from 044fa39 to 16adf4f Compare September 23, 2026 18:00
@jquast
jquast merged commit 8cda5e6 into master Sep 23, 2026
36 of 38 checks passed
@jquast
jquast deleted the jq/bugfix-verylong-csi branch September 23, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant