bugfix width() value for very long CSI sequences - #272
Merged
Merged
Conversation
Merging this PR will improve performance by 86.9%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_width_dense_ansi_control_codes_ignore |
408.8 µs | 218.7 µs | +86.9% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing jq/bugfix-verylong-csi (16adf4f) with master (b3fb5f2)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 87.50% 87.49% -0.01%
==========================================
Files 41 41
Lines 5593 5614 +21
Branches 1494 1501 +7
==========================================
+ Hits 4894 4912 +18
- Misses 323 324 +1
- Partials 376 378 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A case found when making C11 coverage, about measurement mismatch for very-long 64+ byte escape sequences
jquast
force-pushed
the
jq/bugfix-verylong-csi
branch
from
September 23, 2026 18:00
044fa39 to
16adf4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A case found when making tests for C11 coverage, about measurement mismatch for very-long 64+ byte
escape sequences