feat(extension): jev_observe / jev_act for reins do (2/3) - #42
Merged
Merged
Conversation
This was referenced Sep 27, 2026
karngyan
added this pull request to stack #44
September 27, 2026 08:49
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e stale A click whose handler opens alert/confirm/prompt froze jevAct: the press response, the probe read and settle all block on a dialog, so the act sat until the daemon's per-call timeout. jevAct now races the act against a per-tab dialog waiter fed by Page.javascriptDialogOpening; if the dialog wins, the press happened, so it returns ok and the next observe reports the dialog. Transport failures from actionablePoint are rethrown instead of being reported as a stale element. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…end no input
A dialog opened by the page before jev_act's first mutating command now
returns stale ("a dialog opened before the action") instead of ok, since
nothing happened. When a dialog wins the race after the press, the act is
marked abandoned so that, once the dialog is answered and the frozen
command resumes, it sends no selectAll, insertText or settle against
whatever is focused by then.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
karngyan
force-pushed
the
feat/reins-do-extension
branch
from
September 28, 2026 16:09
0d10e11 to
d8171a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 3 for
reins do(stacked on #41; #43 builds on this).Why
Jev needs two things from the page, and both have to be fast:
What
jev_observe: a page snapshot ported from browser-use/jev-ultrafast (MIT). It returns:Nodes are cached page-side in a
Symbol.for("reins.jev")map. Password and hidden values are never included, and a browser test asserts it with a real value in a password field.jev_act: click, type, select, scroll or wait on a cached node. It reuses the existing actionability checks (actionPoint/actionablePointnow accept a node and a timeout;pressAtwas extracted fromcdpClick).Dialogs: tracked via
Page.javascriptDialogOpening/Closed.jev_actraces its work against a dialog opening, so a click that opensconfirm()returns right away instead of hanging.Tiers: both methods need tier
fullinMETHOD_TIERS.Testing
pointer.browser.test.ts, headless Chrome): a Jev fixture page covering the leak test (#pw holding "hunter2", hidden "secret"), a confirm-dialog click, and forwarding of CDP events.🤖 Generated with Claude Code