Type-check the UI in CI - #188
Open
paul-brooks wants to merge 1 commit into
Open
Conversation
viteBuild shells straight to vite, which transpiles through esbuild and strips types without checking them, so the tsc half of the npm build script never ran in CI and type errors reached master. Adds a typeCheck task running tsc --noEmit and puts it ahead of viteBuild. Fixes #187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
viteBuildshells straight to vite, which transpiles through esbuild and strips types without checking them, so thetschalf of the npm build script never ran in CI.Adds a
typeChecktask runningtsc --noEmitand puts it ahead ofviteBuild.Verified it actually gates: reintroducing the
RegExp | nullreturn from #186 fails the task with the twoTS2769errors that previously passed CI.Fixes #187