Delete extensions without implicit cleanup - #67
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 06:57
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 13, 2026 13:34
a789f61 to
992dde3
Compare
IlyaasK
force-pushed
the
hypeship/extension-delete-core
branch
2 times, most recently
from
July 13, 2026 14:32
33d82ee to
d60c9e5
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
2 times, most recently
from
July 13, 2026 15:39
ca7698d to
768706f
Compare
IlyaasK
force-pushed
the
hypeship/extension-delete-core
branch
from
July 13, 2026 15:39
d60c9e5 to
1ed2fbb
Compare
IlyaasK
force-pushed
the
hypeship/extension-delete-core
branch
from
July 20, 2026 19:38
1ed2fbb to
a5debe6
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 21, 2026 14:46
1cbbde5 to
bb43138
Compare
IlyaasK
force-pushed
the
hypeship/extension-delete-core
branch
2 times, most recently
from
July 21, 2026 18:10
25f8375 to
c7cd2bc
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 21, 2026 19:51
55234ad to
83939e3
Compare
IlyaasK
force-pushed
the
hypeship/extension-delete-core
branch
from
July 21, 2026 19:51
c7cd2bc to
1f105b7
Compare
IlyaasK
force-pushed
the
hypeship/extension-delete-core
branch
from
July 21, 2026 20:15
1f105b7 to
cb4e287
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 21, 2026 20:15
83939e3 to
d503c89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
not_foundas converged successresource_in_usedependency contractWhy this is v1 work
This is the pure Delete core needed before Framework Delete and complete resource registration.
Intentionally unsupported
Verification
gofmt -l cmd internal,go test -count=20 ./internal/resources/extension, extension race tests, full short tests,go vet ./...,go mod tidy -diff, andgit diff --checkall passed. Tests use a fake client and no network/container.Acceptance status
No registered complete resource exists yet, so live acceptance testing is not applicable.
Remaining risk
Delete remains blocked while durable browser pools reference the extension. Terraform intentionally does not alter those dependencies implicitly.
Note
Low Risk
New isolated delete helper and tests only; no Framework registration or live resource wiring yet, with explicit non-mutation of browser pools on dependency errors.
Overview
Adds the extension delete core (
deleteExtension) that the Terraform resource will call later: it deletes by stateidandproject_id, validates state before any API call, and maps API outcomes to diagnostics.Idempotent delete: coded
not_foundresponses are treated as success viaprojectscope.IsNotFound. Dependency blocking: only HTTP 400 bodies withresource_in_useare recognized as “in use”; operators get a message to remove durable browser pool references, with no implicit pool or runtime cleanup.Other failures (generic 400/404, transport, missing client) surface as normal delete errors. Unit tests cover scope/identity, not-found success, in-use messaging, error classification, and pre-call state validation.
Reviewed by Cursor Bugbot for commit cb4e287. Bugbot is set up for automated code reviews on this repo. Configure here.