Expose browser pool resolved references - #75
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 10:36
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 13, 2026 13:35
ad9b86d to
2a4d9ad
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
2 times, most recently
from
July 13, 2026 14:32
867f435 to
c957fa0
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 13, 2026 15:39
825994b to
e0f20fd
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 13, 2026 15:39
c957fa0 to
7bfcdff
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 20, 2026 19:38
7bfcdff to
9237b28
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
2 times, most recently
from
July 21, 2026 14:46
63f8898 to
feef7a2
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 21, 2026 14:46
9237b28 to
baf2210
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 21, 2026 18:10
feef7a2 to
d1f6e31
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 21, 2026 18:10
baf2210 to
b19872f
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 21, 2026 19:51
d1f6e31 to
f5464c6
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
2 times, most recently
from
July 21, 2026 20:15
735c9f6 to
6b2c9bc
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-core
branch
from
July 31, 2026 19:17
2da6ca9 to
e1a5354
Compare
Read canonical profile and ordered extension IDs from the SDK response, with strict validation and ID-only fallback for legacy echoes. Keep runtime fields outside Terraform state.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 31, 2026 19:21
6b2c9bc to
7637450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile_idtokernel_browser_poolextension_idsWhy this belongs in v1
This extends the read-only browser-pool data source with stable durable identities. It is additive to the v0 provider and intentionally separate from the core lookup/project-scope PR so canonical-reference semantics can be reviewed independently.
API contract and state semantics
Top-level
profile_idandextension_idsare authoritative becausebrowser_pool_configmay echo name selectors supplied during creation. Authoritative fields always win. For older responses that omit them, fallback succeeds only when the echoed profile/extensions already contain canonical IDs.profile_idomission means no profile; explicit JSON null is rejected because the SDK field is optional but non-nullable. An authoritative emptyextension_idsarray becomes an empty computed Terraform list. Extension order is preserved.Intentionally unsupported in this PR
No v0 behavior is removed or changed.
Tests run
go test -count=20 ./internal/datasources/browserpoolgo test -race ./internal/datasources/browserpool ./internal/providergo test -short -timeout=2m ./...go vet ./...test -z "$(gofmt -l cmd internal)"go mod verifygo mod tidy -diffterraform fmt -check -recursive examplesbash scripts/check-docs.shgit diff --checkTests cover authoritative precedence, legacy ID-only fallback, profile omission, explicit null rejection, empty and ordered extension lists, malformed field types, empty IDs, and selector-name rejection.
Acceptance status
Not run in this PR. Live SDK resolved-reference responses, GET-by-name, and project scoping remain a non-blocking integration risk for the later opt-in acceptance slice.
Note
Low Risk
Additive read-only data source attributes with validation; no writes or changes to existing lookup behavior.
Overview
Adds read-only
profile_idand orderedextension_idsto thekernel_browser_pooldata source so Terraform can reference stable IDs instead of name selectors echoed inbrowser_pool_config.Flattening prefers top-level SDK
profile_id/extension_idswhen present; otherwise it falls back to legacy nested profile/extension objects only when they include canonical IDs (name-only echoes are rejected). Invalid shapes (null profile, malformed lists, empty IDs) surface as diagnostics.Docs and unit tests cover authoritative precedence, legacy fallback, omission, and rejection cases.
Reviewed by Cursor Bugbot for commit 7637450. Bugbot is set up for automated code reviews on this repo. Configure here.