Expose browser pool Chrome policy - #79
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit af40ac2. Configure here.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 13, 2026 13:35
deb65f4 to
df3b49e
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-chrome-policy
branch
2 times, most recently
from
July 13, 2026 14:32
a9c7241 to
dfdb402
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 13, 2026 15:39
16097b4 to
8a4fc9c
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-chrome-policy
branch
from
July 13, 2026 15:39
dfdb402 to
20fff2e
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-chrome-policy
branch
from
July 20, 2026 19:38
20fff2e to
f470d3d
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
2 times, most recently
from
July 21, 2026 14:46
da6aac2 to
330ef3e
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-chrome-policy
branch
2 times, most recently
from
July 21, 2026 18:10
2905808 to
c9a8321
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 21, 2026 19:51
7c63d7e to
38e7266
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-chrome-policy
branch
2 times, most recently
from
July 21, 2026 20:15
220e141 to
a0a227d
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 31, 2026 19:28
1b81db1 to
3825585
Compare
Normalize SDK Chrome-policy JSON into stable Terraform string state. Keep loose maps at the response boundary and preserve absent or null policy compatibility.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-chrome-policy
branch
from
July 31, 2026 19:30
a0a227d to
95039fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Scope
Additive v1 durable read state only. No runtime/session fields. Live acceptance remains separate.
Tests
Ran repeated focused tests, race tests, full short suite, vet, gofmt, module checks, Terraform example fmt, docs drift, and diff checks.
Coverage includes Framework state roundtrip, deterministic nested JSON, HTML-sensitive characters, numeric canonicalization, omission/null, and non-object rejection.
Note
Low Risk
Additive computed read on an existing datasource with no auth or write-path changes; behavior is covered by unit tests.
Overview
Adds a computed read-only
chrome_policyattribute to thekernel_browser_pooldata source so lookups can surface Chrome enterprise policy overrides alongside other durable pool config.API policy JSON is unmarshaled at the SDK boundary, then re-encoded into a stable string: sorted keys, API-style numeric values, no HTML escaping in URLs/tags, and omission or explicit
nullsurfaced as Terraform null. Non-object API values produce diagnostics instead of state.Registry docs and datasource tests cover schema presence, read round-trip, normalization edge cases, and invalid shapes.
Reviewed by Cursor Bugbot for commit 95039fa. Bugbot is set up for automated code reviews on this repo. Configure here.