fix(desktop): restore camera and microphone webview permission - #5
Merged
Merged
Conversation
Re-apply the desktop permission handler that was dropped from main and shipped without it in 0.1.1-beta.1. Commit 9c4bdf4 re-imported an older public branch state as a single-parent commit, deleting the module, the on_webview_ready hook and the target dependencies; the changelog listed the fix but the code was absent. Restore the fix originally introduced in a4d919c: - Add src/desktop_permissions.rs with a testable should_grant policy - Hook on_webview_ready in src/lib.rs - Windows: WebView2 PermissionRequested -> allow camera/microphone - Linux: webkitgtk permission-request -> allow user-media - Add target dependencies webview2-com, windows and webkit2gtk - Add the verify-windows CI job and the Desktop README section This keeps the plugin honest with what it advertises on desktop: getUserMedia works on Windows and Linux without extra consumer configuration.
The fix in d7e2083 restores the permission handler that was lost from the 0.1.1-beta.1 release. This patch change file lets covector open the release PR and publish 0.1.1-beta.2 from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.