Track and expose Module Overloading evasion techniques - #199
Open
doomedraven wants to merge 3 commits into
Open
Conversation
…erloading detection
## Issues Fixed
1. **Use-After-Free in Dynamic Module Name Resolution**
- Fixed memory management bug where `dynamic_module_name.Buffer` pointed
directly into freed `absolutepath` memory in:
- NtMapViewOfSection
- NtMapViewOfSectionEx
- NtProtectVirtualMemory
- VirtualProtectEx
- Solution: Use stack-allocated basename_buffer instead of pointing into
freed heap memory. Buffer now stays valid through logging calls.
2. **Missing NULL Check for get_dll_basename()**
- Added NULL check before using basename to prevent potential crashes
or invalid logging in all four functions.
3. **Format String Mismatch in NtCreateSection**
- Fixed format string from "PhopiipF" (8 characters) to "PhopipF" (7 characters)
- Was causing logging macro to misinterpret parameters when accessing
FileHandle and FileName fields.
4. **Improved Memory Safety**
- basename_buffer properly null-terminated with bounds checking
- Prevents buffer overruns and use-after-free scenarios
The fixes ensure module names are captured safely during module overloading
detection without risk of memory corruption or crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.