Skip to content

fix: make release-please compatible with workspace versions#69

Merged
archae0pteryx merged 6 commits into
mainfrom
fix/release-please-simple
May 21, 2026
Merged

fix: make release-please compatible with workspace versions#69
archae0pteryx merged 6 commits into
mainfrom
fix/release-please-simple

Conversation

@archae0pteryx

@archae0pteryx archae0pteryx commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • switch Release Please to the node strategy so it avoids the Rust strategy's virtual-workspace root updater
  • make crate versions explicit instead of version.workspace so version files are directly updateable
  • configure Release Please extra-files for all Rust manifests, Cargo.lock, Tauri config, and npm package files

Verification

  • rtk task check
  • rtk npx release-please release-pr --repo-url=killallgit/adhd-ranch --target-branch=fix/release-please-simple --config-file=release-please-config.json --manifest-file=.release-please-manifest.json --dry-run --debug --token=...

Notes

The dry run exits 0 and shows Release Please would open a 0.2.0 release PR, updating package-lock.json, package.json, all Rust manifests, Cargo.lock, src-tauri/tauri.conf.json, CHANGELOG.md, and .release-please-manifest.json.

Summary by CodeRabbit

  • Chores
    • Updated version management configuration across multiple package manifests to use explicit version declarations instead of workspace inheritance.
    • Modified release configuration to support an updated release workflow process.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 91322aaa-7710-452b-80a1-f387f2f0a518

📥 Commits

Reviewing files that changed from the base of the PR and between 0b616ed and 88fe630.

📒 Files selected for processing (7)
  • Cargo.toml
  • crates/commands/Cargo.toml
  • crates/domain/Cargo.toml
  • crates/http-api/Cargo.toml
  • crates/storage/Cargo.toml
  • release-please-config.json
  • src-tauri/Cargo.toml
💤 Files with no reviewable changes (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

This PR decentralizes version management by removing workspace-level version inheritance and explicitly declaring version = "0.0.0" in all crate manifests. The release-please configuration is simultaneously updated to work with the new structure using node release-type and explicit extra-files version mappings.

Changes

Version Management Decentralization

Layer / File(s) Summary
Workspace and crate manifest version updates
Cargo.toml, crates/commands/Cargo.toml, crates/domain/Cargo.toml, crates/http-api/Cargo.toml, crates/storage/Cargo.toml, src-tauri/Cargo.toml
Root Cargo.toml removes workspace-level version, and all child crates transition from version.workspace = true to explicit version = "0.0.0".
Release-please automation configuration
release-please-config.json
Release-please release-type changes from rust to node, and extra-files array expands with TOML mappings to extract versions from all Cargo.toml files and Cargo.lock package entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • killallgit/adhd-ranch#68: Both PRs modify release-please-config.json to change how Release Please reads Rust crate versions (removing the cargo-workspace plugin in #68 and adjusting release-type/extra-files in this PR).

Poem

🐰 Versions once nested in workspace's keep,
Now each crate declares its own deep,
Release Please learns the new refrain—
Node-type wisdom, TOML's domain!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: switching from workspace-based versioning to explicit crate versions and configuring release-please for compatibility with this approach.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-please-simple

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@archae0pteryx archae0pteryx merged commit a974b9d into main May 21, 2026
4 checks passed
@archae0pteryx archae0pteryx deleted the fix/release-please-simple branch May 21, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant