Skip to content

Fix 3 out of bound reads #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdj0c merged 3 commits into from
Aug 14, 2026
Merged

Fix 3 out of bound reads #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7d1339
screen: Fix out-of-bounds read in tsm_screen_tab_left()
glitchfox Aug 14, 2026
cdd725d
vte: Fix OSC 4 color index
glitchfox Aug 14, 2026
60c595d
vte: Fix Out-of-bounds READ in csi_attribute
glitchfox Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/tsm/tsm-screen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,6 +1349,11 @@ void tsm_screen_tab_left(struct tsm_screen *con, unsigned int num)
screen_inc_age(con);

x = con->cursor_x;

/* cursor_x may exceed size_x (e.g. CHT then a wide glyph at the last
* column); clamp before indexing tab_ruler[0..size_x-1]. */
if (x > con->size_x)
x = con->size_x;
for (i = 0; i < num; ++i) {
for (j = x - 1; j > 0; --j) {
if (con->tab_ruler[j])
Expand Down
10 changes: 10 additions & 0 deletions src/tsm/tsm-vte.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1306,6 +1306,12 @@ static void greyscale_rgb(int code, uint8_t *cr, uint8_t *cg, uint8_t *cb)
static void lookup_color(struct tsm_vte *vte, int color, uint8_t *cr,
uint8_t *cg, uint8_t *cb)
{
/* OSC-4 / SGR color indices are untrusted; an out-of-range (or
* unsigned-overflow-negative) index would wild-read palette[]/bval[]. */
if (color < 0 || color > 255) {
*cr = *cg = *cb = 0;
return;
}
if (color < 16) {
palette_rgb(vte, color, cr, cg, cb);
} else if (color < 232) {
Expand Down Expand Up @@ -1479,6 +1485,10 @@ static void csi_attribute(struct tsm_vte *vte)
/* fallthrough */
case 48:
val = vte->csi_argv[i];
/* the 5/2 subcommand + its operands live in later argv slots;
* bail if they would read past the parsed args (csi_argv[16] OOB). */
if (i + 1 >= vte->csi_argc)
break;
if (vte->csi_argv[i + 1] == 5) { // 256color mode
if (i + 2 >= vte->csi_argc ||
vte->csi_argv[i + 2] < 0) {
Expand Down
Loading