Skip to content

docs: update Terraform reference - service accounts and controls (v0.7.0, v0.8.0)#323

Merged
mbevc1 merged 1 commit into
mainfrom
mintlify/38b085b7
Jul 10, 2026
Merged

docs: update Terraform reference - service accounts and controls (v0.7.0, v0.8.0)#323
mbevc1 merged 1 commit into
mainfrom
mintlify/38b085b7

Conversation

@mintlify

@mintlify mintlify Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Add Terraform reference pages for the new kosli_service_account, kosli_service_account_api_key, and kosli_control resources and data sources released in terraform-provider-kosli v0.7.0 and v0.8.0.

Changes

  • Added terraform-reference/resources/service_account.mdx (new in v0.7.0)
  • Added terraform-reference/resources/service_account_api_key.mdx (new in v0.7.0)
  • Added terraform-reference/data-sources/service_account.mdx (new in v0.7.0)
  • Added terraform-reference/resources/control.mdx (new in v0.8.0, beta)
  • Added terraform-reference/data-sources/control.mdx (new in v0.8.0, beta)
  • Registered all five pages in config/navigation.json under the Terraform Reference Resources and Data Sources groups

Context

  • v0.7.0 (July 7, 2026): added service account resources and data source
  • v0.8.0 (July 8, 2026): added kosli_control resource and data source (beta)

@mintlify mintlify Bot requested a review from a team as a code owner July 10, 2026 09:41
@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Claude finished @mintlify[bot]'s task in 2m 1s —— View job


PR Review: Terraform Reference Pages

  • Read CLAUDE.md and doc-review skill
  • Read all changed files
  • Check navigation registration
  • Check for relative links and content issues
  • Post review findings

Review summary

This PR adds five well-structured Terraform reference pages for kosli_service_account, kosli_service_account_api_key, and kosli_control (resources and data sources). The pages are consistent with the existing Terraform reference style, follow CLAUDE.md conventions, and are properly registered in navigation.

Checklist

Check Result
All new pages in config/navigation.json Pass — all 5 pages registered
No relative links Pass — all links are root-relative
Frontmatter (title, description, icon) Pass — all pages have complete frontmatter
Internal links resolve Pass — all cross-references point to existing pages
Writing style (active voice, "Kosli" not "the Kosli platform") Pass
Diátaxis classification Pass — all pages are reference docs with correct structure

Findings

No critical issues or improvements found.

Suggestions (3) — see inline comments:

  1. terraform-reference/resources/service_account.mdx (lines 60–62): The "Managing API keys" section repeats the same cross-links already in the intro paragraph (lines 7, 13). Consider removing to reduce redundancy.

  2. terraform-reference/data-sources/control.mdx (lines 30–37): The example creates a resource then immediately reads it via data source in the same config. A standalone data source lookup with a hardcoded identifier would better illustrate the "reference an existing resource managed outside Terraform" use case.

  3. terraform-reference/data-sources/service_account.mdx (lines 26–36): Same pattern — consider a standalone data source example for a more realistic use case.

Overall assessment

Clean PR. The new pages are well-written, thorough, and consistent with existing Terraform reference pages. All conventions from CLAUDE.md are followed. The three suggestions above are minor style improvements — none block merging.

@mintlify

mintlify Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
kosli 🟢 Ready View Preview Jul 10, 2026, 9:44 AM

Comment thread terraform-reference/resources/service_account.mdx
Comment thread terraform-reference/data-sources/control.mdx
Comment thread terraform-reference/data-sources/service_account.mdx
@mbevc1 mbevc1 changed the title Update Terraform reference: service accounts and controls (v0.7.0, v0.8.0) docs: update Terraform reference - service accounts and controls (v0.7.0, v0.8.0) Jul 10, 2026
@mbevc1 mbevc1 enabled auto-merge (squash) July 10, 2026 10:26
@mbevc1 mbevc1 merged commit adbb493 into main Jul 10, 2026
7 of 8 checks passed
@mbevc1 mbevc1 deleted the mintlify/38b085b7 branch July 10, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant