Cuda13 - #57
Merged
Merged
Cuda13#57
Conversation
Add accessors to internals, optimizations, fixes to threadsafety
Recommend running meson tests in --verbose mode to get actual test output.
Expose hash function
Bring different master branches together
…ketdata Include const accessor to exposing hash map buckets
… to fit 2nd approach
splitvector move constructor and swap, Memtest
On AMD/HIP, use memAdvice to set unified memory allocations to be coa…
…ented for custom allocator
Both unit_tests/custom_allocator/unit.cu and unit_tests/memtest/memtest.cu existed but were never wired into meson.build, so they were skipped by `meson test` (the CI test entrypoint). Also add the missing <cstdint> include in memtest.h, needed for the memtest target to actually compile under this toolchain.
- unit_tests/benchmark/main.cu: <nvToolsExt.h> moved under nvtx3/ in modern CUDA (NVTX v3, header-only, no library to link against). Updated the include path and dropped the now-nonexistent -lnvToolsExt link arg from the bench/streamBench targets in meson.build. - unit_tests/hashmap_unit_test/main.cu: std::random_shuffle is deprecated and trips -Werror=deprecated-declarations under GCC 15. Replaced with std::shuffle + std::mt19937, matching the RNG idiom already used elsewhere in this file.
Add -DNOPROFILE as a default global compile define (cpp and cuda), matching the existing -DHASHMAPDEBUG pattern. Guard benchmark/main.cu's NVTX include and PROFILE_START/PROFILE_END behind it, falling back to no-op macros, so the meson build no longer depends on nvtx3/nvToolsExt.h being present/discoverable at all by default.
Contributor
Author
|
Looks like this didn't go to the right base branch. Anyway, we also need to fix the copyright for the PR/repo before merging. |
kstppd
self-requested a review
September 24, 2026 07:30
kstppd
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.