Skip to content

Stamp welcome cards in, fade the scrim, and add a debug reset - #311

Merged
kyleve merged 3 commits into
mainfrom
codex/welcome-scrim-fade
Sep 7, 2026
Merged

Stamp welcome cards in, fade the scrim, and add a debug reset#311
kyleve merged 3 commits into
mainfrom
codex/welcome-scrim-fade

Conversation

@kyleve

@kyleve kyleve commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fade the welcome-card scrim during presentation and dismissal. Previously, the card's scale-and-offset transition also transformed the full-screen scrim.
  • Keep the overlay mounted and transition its scrim and card independently. Replace the shared 0.62-second motion with a 0.3-second tilted stamp arrival and a 0.16-second lift-and-fade departure. Reduce Motion uses a 0.16-second fade, and later presentations restore accessibility focus.
  • Add Reset Welcome Card beside the welcome-card toggle in Settings > Appearance, only in debug builds. It clears the saved welcome region so returning to Locations can show the card again, using the normal recording and location checks.
  • Keep the reset disabled while welcome cards are off. Localize its title and instructions, include it in Settings search, and update all ten Appearance references.

Testing

  • ./swiftformat --lint — passed.
  • ./test --snapshots --only WhereUISnapshotTests/LocationsViewSnapshotTests — passed (1 suite), including architecture validation and rule tests.
  • ./test --only WhereUITests/LocationWelcomeModelTests --only WhereUITests/SettingsSearchTests — passed (23 tests). The reset regression covers replaying the same region in the same model and preserving the disabled preference.
  • ./test --only WhereUITests/WhereStylesheetTests --only WhereUITests/LocationWelcomeModelTests — passed (40 tests), including arrival, departure, scrim, and Reduce Motion token assertions.
  • ./test --snapshots --no-generate --no-build --only WhereUISnapshotTests/AppearanceSettingsViewSnapshotTests — passed (1 suite, 10 reviewed references).
  • ./sf-symbols --lint and ./xcstrings --lint — passed.
  • git diff --check — passed.
  • The snapshots verify settled layouts. Live motion review remains pending because Simulator is unavailable through the connected UI controls. The debug reset supports replaying the transition on-device.

@kyleve kyleve changed the title fix(WhereUI): fade welcome scrim independently of card motion Improve welcome-card transitions and add a debug reset Sep 7, 2026
@kyleve kyleve changed the title Improve welcome-card transitions and add a debug reset Stamp welcome cards in, fade the scrim, and add a debug reset Sep 7, 2026
@kyleve
kyleve enabled auto-merge (squash) September 7, 2026 03:05
@kyleve
kyleve merged commit 5f65b9f into main Sep 7, 2026
7 checks passed
kyleve added a commit that referenced this pull request Sep 7, 2026
> _Posted by an AI agent on kve's behalf._

## Summary

- Reconcile all 12 area backlogs with source through PR #311
(`5f65b9f0`), including PR #309 that the previous report's stated source
coverage missed. The inbox is empty.
- Archive three entries: shipped logged-in/out scope modeling, shipped
local ingest/manual-sample fan-out, and the corrected WhereCore
documentation cluster. Keep the summary, picker, and other partially
implemented work open.
- File two welcome follow-ups: foreground lookup refresh and
scrolling/modal snapshot coverage. Narrow the current-location marker
request to what remains after the welcome feature.
- Correct overstated failure claims, moved citations, test/reference
counts, and snapshot backlog formatting. Document actual reconciliation
and snapshot-model-sharing limitations.
- Refresh `MODULE_AUDIT.md` with the commit boundary, module checks, and
a derived inventory: 709 source files, 371 test/support files, 49
image-suite files, 495 references, and 25 test bundles.

## Review focus

- The welcome foreground finding follows from the retained view's
unchanged task key; its entry explicitly calls for a device reproduction
before choosing the final trigger. No runtime fix is claimed here.
- Snapshot model sharing remains open even though its misleading
documentation is corrected. Priorities are preserved.
- The September 9 benchmark-plan downgrade remains a saved deadline, not
freshly verified billing state. The benchmark repository still exists
and is not archived.

## Verification

- `./swiftformat --lint` — passed; 0/1,136 files require formatting, 125
skipped. The sandbox initially prevented writing the optional formatter
cache; lint itself passed.
- `./shellcheck` — passed.
- `./attribution --check` — passed; 12 credits current.
- `./snapshot-shards check` — passed; 49 suites assigned 13/15/18 plus 3
intake.
- `./sync-agents` — passed after instruction changes; generated files
remain ignored.
- `git diff --check` — passed. Both Swift diffs contain comments only.
- `./test`, architecture execution, simulator/image suites, and retained
Python/Ruby suites were skipped: this change contains Markdown and
comments only, with no executable, reference-image, matrix, or
rendered-copy changes. No fresh visual or live-motion validation is
claimed. The automation's Linux/static-analysis limitations are
preserved; this run used macOS host checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant