Conversation
beekld
added this pull request to stack #608
September 11, 2026 18:04
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 11, 2026 21:23
e03fed7 to
d3da070
Compare
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
2 times, most recently
from
September 12, 2026 00:21
22c46d4 to
ae8dc46
Compare
beekld
marked this pull request as ready for review
September 12, 2026 00:21
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
2 times, most recently
from
September 16, 2026 20:56
7d79b26 to
c3faa16
Compare
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 16, 2026 21:25
c3faa16 to
b53a79c
Compare
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 17, 2026 00:03
b53a79c to
f52848a
Compare
Contributor
Author
|
This PR needs some more work on thread safety. Because the store can outlive the data source, the mechanism that worked in the server code isn't 100% sufficient for client code. I'll comment again when it's ready. |
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 17, 2026 22:09
f52848a to
b387a57
Compare
Contributor
Author
|
Okay, I think I fixed the fence issues by adding a future that gets taken and not resolved until any outstanding writes finish. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b387a57. Configure here.
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 18, 2026 16:57
ab7869c to
4b40610
Compare
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 24, 2026 21:14
4b40610 to
bb64e46
Compare
Base automatically changed from
bklimt/SDK-3031/client-fdv2-streaming
to
main
September 24, 2026 21:26
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 24, 2026 21:26
bb64e46 to
56b64c8
Compare
beekld
force-pushed
the
bklimt/SDK-3032/client-fdv2-orchestrator
branch
from
September 24, 2026 21:29
56b64c8 to
d43a97c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds the client SDK's FDv2 data source -- the orchestrator that runs initializers to load a basis, then rotates synchronizers to keep it current.
Implemented here:
Also moves the shared orchestration primitives out of the server SDK into
libs/internalso both SDKs can share them. That server change is a behavior-neutral relocation.Notes:
Start()blocks on cache initialization, so cached flags are immediately evaluable. This matches the behavior of the FDv1 client. It also matches Android. However, Flutter loads the cache asynchronously instead.Note
Overview
Introduces
FDv2DataSourcefor the client SDK: it chains initializers (including synchronous cache loads beforeStart()returns), then synchronizers with fallback/recovery conditions, applies changesets to the flag store, publishes data-source status, tracks environment id, and marks cache vs network applies. Shutdown is guarded so late results cannot overwrite a replacement source after identify.Shared FDv2 orchestration (
Conditions,SourceManager, condition interfaces) moves from the server SDK intolibs/internal, underlaunchdarkly::internal::data_sources. Conditions now take aSourceSignalenum instead of full synchronizer results;SourceManageris a header-only template usable by both SDKs. The serverFDv2DataSystemis updated to consume the shared headers (behavior-neutral relocation aside from the signal mapping).Adds broad unit tests for the client orchestrator and adjusts internal/server tests for the new namespaces and APIs.
.gitignoreignores.envand.claude.Reviewed by Cursor Bugbot for commit 91a3f35. Bugbot is set up for automated code reviews on this repo. Configure here.