chore: fix README formatting in the OpenFeature server packages - #2046
Closed
tanderson-ld wants to merge 2 commits into
Closed
tanderson-ld wants to merge 2 commits into
tanderson-ld wants to merge 2 commits into
Conversation
Contributor
|
@tanderson-ld I think we can close this as the changes were done upstream |
tanderson-ld
marked this pull request as ready for review
September 25, 2026 17:51
Contributor
Author
|
Superseded: #2044 landed identical formatting for both READMEs on main (byte-identical output from the same formatter), so this branch's diff against main is now empty. Closing; no follow-up needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
openfeature-node-serverandopenfeature-cloudflare-serverREADMEs failformat:check, which breaks those packages' path-triggered CI workflows. Because the workflows only run when their paths change, the failure lies dormant onmainand surfaces on any PR that touches shared code those packages depend on (first observed on #2045, whose own files are format-clean).Formatting-only change produced by running the packages'
formatscripts; two lines total. The repo-wideformat:checkpasses with this applied.Note
Overview
Applies formatting-only fixes to the READMEs in
openfeature-node-serverandopenfeature-cloudflare-server(two lines total via each package’sformatscript) so those workspaces passformat:check.That unblocks path-triggered CI for those packages, which had been failing on
mainuntil something touched their paths.Reviewed by Cursor Bugbot for commit 973ce5d. Bugbot is set up for automated code reviews on this repo. Configure here.