Repository navigation
Add golden tests for the sequence document - #633
Merged
Merged
Conversation
- generate_doc.py: set the log level when run (default WARNING, LOG_LEVEL to override) instead of DEBUG at import - mogrifier.py: log selections missing from the payload at INFO - generateDoc: log the script output once instead of per chunk - CI: start the server with ts-node, since the tests write files that restart nodemon - Sequence unit test: create its output directory
Collaborator
Author
|
@JayHuLBL This is ready for review and merge. |
JayHuLBL
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses #632.
It adds a long awaited test suite reproducing payloads from mocked UI selections and generating documentation out of these payloads for 52 system configs. Impact on server test runtime ~ 1 min.
Some minor restructuring of the client code was needed.
This is a first step, to secure the development planned in #620.
This PR also includes the detailed specification for #620 in
docs/selection-keys.md.Testing
See #621 for the description of the new tests included in CI.