Repository navigation
Add a centralized scanner for Modelica names - #638
Open
AntoineGautier wants to merge 3 commits into
Open
AntoineGautier wants to merge 3 commits into
AntoineGautier wants to merge 3 commits into
Conversation
- ConfigInterface.projectId, set by configStore.add() to the active project - Scope config store queries and removals to a project (active by default); add removeAllForProject, used when saving the project details - Save the default project once hydrated, so that its id does not change on reload - Once both stores are hydrated, attach configurations without a valid project to the project if there is only one, report them otherwise - Create the default project per store instance
- Add a scanner for Modelica names (server/src/parser/names.ts, also imported by the client): split, first/last identifier, enclosing name, validation, selection key split - Use it for every name split in the server parser and the client - Keep quoted identifiers as written: MLS 2.3.1 makes \? and ? the same, but Dymola and OCT do not, and keys must give modifications these tools accept - Reject quoted class identifiers when reading modelica-json files - Recognize names with quoted identifiers as values (quoted enumeration literals) - Add test packages with quoted identifiers, parser and interpreter tests, and scanner unit tests - Remove the obsolete root docker-compose.yml (EC2 deployment replaced by the CDK stack) - Update the specification
Collaborator
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is for #635.
Built on top of #637.
The Modelica name scanner is shared between the server (where it lives:
server/src/parser/names.ts) and the client (where it is imported).The parser output
templates.jsonis byte-identical to the one on main.