Repository navigation
Conversation
lcnr
force-pushed
the
next-solver-ui-test-diff
branch
from
October 12, 2026 12:38
75baf7d to
9cfb290
Compare
lcnr
force-pushed
the
next-solver-ui-test-diff
branch
from
October 12, 2026 12:49
9cfb290 to
0bc2f3c
Compare
estebank
reviewed
Oct 13, 2026
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
Random observations, I think some of these can be brought up to the quality we expect with some focused effort.
Comment on lines
+33
to
+43
| error[E0277]: the trait bound `(dyn Trait + 'static): Trait` is not satisfied | ||
| --> $DIR/associated-const-in-trait.rs:9:29 | ||
| | | ||
| LL | const fn n() -> usize { Self::N } | ||
| | ^^^^ the trait `Trait` is not implemented for `(dyn Trait + 'static)` | ||
| | | ||
| help: this trait has no implementations, consider adding one | ||
| --> $DIR/associated-const-in-trait.rs:3:1 | ||
| | | ||
| LL | trait Trait { | ||
| | ^^^^^^^^^^^ |
There was a problem hiding this comment.
I wish we silenced these kind of errors (that are already implied by others)
Comment on lines
-19
to
-25
| | | ||
| note: required by a bound in `Ty::Pr` | ||
| --> $DIR/generic-associated-types-bad.rs:10:16 | ||
| | | ||
| LL | impl Ty { | ||
| LL | type Pr<T: Copy> = T; | ||
| | ^^^^ required by this bound in `Ty::Pr` |
There was a problem hiding this comment.
Why do we lose these? We don't carry an appropriate obligation cause code?
Comment on lines
-87
to
-89
| LL | | ||
| LL | iter::empty::<*const ()>() | ||
| | -------------------------- return type was inferred to be `std::iter::Empty<*const ()>` here |
There was a problem hiding this comment.
I suspect that recovering the "point at the return expression(s)" logic in the new solver should be doable? Might possibly need replacing some obligation cause codes so that appropriate info is tracked though.
Comment on lines
+105
to
+109
| error[E0284]: type annotations needed: cannot satisfy `<impl Iterator<Item = u32> as Iterator>::Item == i32` | ||
| --> $DIR/duplicate-bound-err.rs:103:17 | ||
| | | ||
| LL | fn foo() -> impl Iterator<Item = i32, Item = u32> { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `i32`, found `u32` | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot satisfy `<impl Iterator<Item = u32> as Iterator>::Item == i32` |
Comment on lines
+43
to
61
| error[E0277]: the trait bound `for<'x, 'y> Tuple: TheTrait<(&'x isize, &'y isize)>` is not satisfied | ||
| --> $DIR/associated-types-eq-hr.rs:96:17 | ||
| | | ||
| LL | tuple_one::<Tuple>(); | ||
| | ^^^^^^^^^^^^^^^^^^^^ | ||
| | ^^^^^ unsatisfied trait bound | ||
| | | ||
| note: `Tuple` must implement `TheTrait<(&'0 isize, &'1 isize)>`, for any two lifetimes `'0` and `'1`... | ||
| --> $DIR/associated-types-eq-hr.rs:59:8 | ||
| | | ||
| LL | fn tuple_one<T>() | ||
| LL | where | ||
| LL | T: for<'x, 'y> TheTrait<(&'x isize, &'y isize), A = &'x isize>, | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `tuple_one` | ||
| note: ...but it actually implements `TheTrait<(&'2 isize, &'2 isize)>`, for some specific lifetime `'2` | ||
| help: the trait `TheTrait<(&'x _, &'y _)>` is not implemented for `Tuple` | ||
| but trait `TheTrait<(&_, &_)>` is implemented for it | ||
| --> $DIR/associated-types-eq-hr.rs:35:1 | ||
| | | ||
| LL | impl<'a> TheTrait<(&'a isize, &'a isize)> for Tuple { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| error: implementation of `TheTrait` is not general enough | ||
| --> $DIR/associated-types-eq-hr.rs:96:5 | ||
| | | ||
| LL | tuple_one::<Tuple>(); | ||
| | ^^^^^^^^^^^^^^^^^^^^ | ||
| | | ||
| note: `Tuple` must implement `TheTrait<(&'0 isize, &'1 isize)>`, for any two lifetimes `'0` and `'1`... | ||
| note: required by a bound in `tuple_one` | ||
| --> $DIR/associated-types-eq-hr.rs:59:8 | ||
| | | ||
| LL | fn tuple_one<T>() | ||
| LL | where | ||
| LL | T: for<'x, 'y> TheTrait<(&'x isize, &'y isize), A = &'x isize>, | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `tuple_one` |
Comment on lines
+13
to
+35
| error[E0275]: overflow evaluating the requirement `<bool as Tr>::B == _` | ||
| --> $DIR/defaults-cyclic-fail-1.rs:26:5 | ||
| | | ||
| LL | type A = Box<Self::B>; | ||
| | ^^^^^^ | ||
|
|
||
| error[E0275]: overflow evaluating whether `Box<<bool as Tr>::B>` is well-formed | ||
| --> $DIR/defaults-cyclic-fail-1.rs:26:5 | ||
| | | ||
| LL | type A = Box<Self::B>; | ||
| | ^^^^^^ | ||
|
|
||
| error[E0275]: overflow evaluating the requirement `<usize as Tr>::A == _` | ||
| --> $DIR/defaults-cyclic-fail-1.rs:32:5 | ||
| | | ||
| LL | type B = &'static Self::A; | ||
| | ^^^^^^ | ||
|
|
||
| error[E0275]: overflow evaluating whether `&'static <usize as Tr>::A` is well-formed | ||
| --> $DIR/defaults-cyclic-fail-1.rs:32:5 | ||
| | | ||
| LL | type B = &'static Self::A; | ||
| | ^^^^^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all non-revision UI test diffs. Based on
-Znext-solverrust-lang/rust#163928Found issues in the first 100 tests
Carrier<'b>::Focus<i32>" to "overflow evaluating the requirementfor<'b> Carrier<'b>::Focus<i32> == _"isize"Self: Sizederrors don't get dedup'dmovesuggestionPinhere even though we maybe should 🤔(), the traitFn()is not implemented for()" what?